Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: services/video_capture/video_capture_service_unittest.cc

Issue 2494033004: [Mojo Video Capture] Use string keys instead of VideoCaptureDeviceDescriptor (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/video_capture/video_capture_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/video_capture/video_capture_service_unittest.cc
diff --git a/services/video_capture/video_capture_service_unittest.cc b/services/video_capture/video_capture_service_unittest.cc
index d7ada5157ea79c2f88e2bcfd51b772289eacd566..4b1c7029d669bdbae95c95f2cc66733b312ac08e 100644
--- a/services/video_capture/video_capture_service_unittest.cc
+++ b/services/video_capture/video_capture_service_unittest.cc
@@ -54,9 +54,7 @@ TEST_F(VideoCaptureServiceTest, FakeDeviceFactoryEnumeratesOneDevice) {
// Tests that VideoCaptureDeviceFactory::CreateDeviceProxy() returns an error
// code when trying to create a device for an invalid descriptor.
TEST_F(VideoCaptureServiceTest, ErrorCodeOnCreateDeviceForInvalidDescriptor) {
- media::VideoCaptureDeviceDescriptor invalid_descriptor;
- invalid_descriptor.device_id = "invalid";
- invalid_descriptor.model_id = "invalid";
+ const std::string invalid_device_id = "invalid";
base::RunLoop wait_loop;
mojom::VideoCaptureDeviceProxyPtr fake_device_proxy;
MockCreateDeviceProxyCallback create_device_proxy_callback;
@@ -65,7 +63,7 @@ TEST_F(VideoCaptureServiceTest, ErrorCodeOnCreateDeviceForInvalidDescriptor) {
.Times(1)
.WillOnce(InvokeWithoutArgs([&wait_loop]() { wait_loop.Quit(); }));
factory_->CreateDeviceProxy(
- std::move(invalid_descriptor), mojo::GetProxy(&fake_device_proxy),
+ invalid_device_id, mojo::GetProxy(&fake_device_proxy),
base::Bind(&MockCreateDeviceProxyCallback::Run,
base::Unretained(&create_device_proxy_callback)));
wait_loop.Run();
« no previous file with comments | « services/video_capture/video_capture_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698