Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: services/video_capture/device_factory_media_to_mojo_adapter.h

Issue 2494033004: [Mojo Video Capture] Use string keys instead of VideoCaptureDeviceDescriptor (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/video_capture/device_factory_media_to_mojo_adapter.h
diff --git a/services/video_capture/device_factory_media_to_mojo_adapter.h b/services/video_capture/device_factory_media_to_mojo_adapter.h
index f4fc0da8407b007b5e620b404d508159ba1948ff..fb026c64e59cd3840f13bde3545d97fe94a85082 100644
--- a/services/video_capture/device_factory_media_to_mojo_adapter.h
+++ b/services/video_capture/device_factory_media_to_mojo_adapter.h
@@ -34,12 +34,11 @@ class DeviceFactoryMediaToMojoAdapter
void EnumerateDeviceDescriptors(
const EnumerateDeviceDescriptorsCallback& callback) override;
void GetSupportedFormats(
- const media::VideoCaptureDeviceDescriptor& device_descriptor,
+ const std::string& device_id,
const GetSupportedFormatsCallback& callback) override;
- void CreateDeviceProxy(
- const media::VideoCaptureDeviceDescriptor& device_descriptor,
- mojom::VideoCaptureDeviceProxyRequest proxy_request,
- const CreateDeviceProxyCallback& callback) override;
+ void CreateDeviceProxy(const std::string& device_id,
+ mojom::VideoCaptureDeviceProxyRequest proxy_request,
+ const CreateDeviceProxyCallback& callback) override;
private:
struct ActiveDeviceEntry {
@@ -55,13 +54,13 @@ class DeviceFactoryMediaToMojoAdapter
std::unique_ptr<mojo::Binding<mojom::VideoCaptureDeviceProxy>> binding;
};
- void OnClientConnectionErrorOrClose(
- const media::VideoCaptureDeviceDescriptor& descriptor);
+ void OnClientConnectionErrorOrClose(const std::string& device_id);
+ void RefreshDescriptors();
const std::unique_ptr<media::VideoCaptureDeviceFactory> device_factory_;
const media::VideoCaptureJpegDecoderFactoryCB jpeg_decoder_factory_callback_;
- std::map<media::VideoCaptureDeviceDescriptor, ActiveDeviceEntry>
- active_devices_;
+ std::map<std::string, media::VideoCaptureDeviceDescriptor> descriptors_by_id_;
+ std::map<std::string, ActiveDeviceEntry> active_devices_by_id_;
};
} // namespace video_capture

Powered by Google App Engine
This is Rietveld 408576698