Issue 2494033003: Move IOSChromePhysicalWebDataSource to ios/chrome/browser

Issue 2494033003: Move IOSChromePhysicalWebDataSource to ios/chrome/browser (Closed)

Created:
4 years, 1 month ago by mattreynolds

Modified:
4 years, 1 month ago

Reviewers:
sdefresne

CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Move IOSChromePhysicalWebDataSource to ios/chrome/browser BUG=630769 Committed: https://crrev.com/c80d673f7881fa9cf9d32d0af6a4b688f8740c8f Cr-Commit-Position: refs/heads/master@{#431957}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -103 lines)			Patch
M	ios/chrome/browser/physical_web/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ios/chrome/browser/physical_web/create_physical_web_data_source.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ios/chrome/common/physical_web/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.h	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.mm	View	1 chunk	+0 lines, -50 lines	0 comments	Download

Total messages: 11 (5 generated)

mattreynolds

Hi Sylvain, PTAL Let's move the iOS implementation of the Physical Web data source into ...

4 years, 1 month ago (2016-11-11 19:18:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494033003/1

4 years, 1 month ago (2016-11-14 18:43:54 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494033003/1

4 years, 1 month ago (2016-11-14 22:33:34 UTC) #8

commit-bot: I haz the power

4 years, 1 month ago (2016-11-14 23:22:58 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c80d673f7881fa9cf9d32d0af6a4b688f8740c8f
Cr-Commit-Position: refs/heads/master@{#431957}