Issue 24940002: Send ChromeViewMsg_SearchBoxSetSuggestionToPrefetch IPC message from SearchIPCRouter.

Issue 24940002: Send ChromeViewMsg_SearchBoxSetSuggestionToPrefetch IPC message from SearchIPCRouter. (Closed)

Created:
7 years, 2 months ago by kmadhusu

Modified:
7 years, 2 months ago

Reviewers:
Jered

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Send ChromeViewMsg_SearchBoxSetSuggestionToPrefetch IPC message from SearchIPCRouter. BUG=272583 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226346

Patch Set 1 : '' #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Addressed comment #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -31 lines)			Patch
M	chrome/browser/ui/search/instant_controller.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/search/instant_ipc_sender.h	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/search/instant_ipc_sender.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router.h	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router_policy_impl.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router_policy_impl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router_policy_unittest.cc	View	1 2 3	9 chunks	+22 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router_unittest.cc	View	1 2 3	7 chunks	+39 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jered

lgtm https://codereview.chromium.org/24940002/diff/9001/chrome/browser/ui/search/search_ipc_router_policy_unittest.cc File chrome/browser/ui/search/search_ipc_router_policy_unittest.cc (right): https://codereview.chromium.org/24940002/diff/9001/chrome/browser/ui/search/search_ipc_router_policy_unittest.cc#newcode49 chrome/browser/ui/search/search_ipc_router_policy_unittest.cc:49: ASSERT_TRUE(search_tab_helper->ipc_router().policy()-> Here and below, use EXPECT_ instead of ...

7 years, 2 months ago (2013-10-01 17:41:55 UTC) #2

kmadhusu

Addressed comment. Thanks. https://codereview.chromium.org/24940002/diff/9001/chrome/browser/ui/search/search_ipc_router_policy_unittest.cc File chrome/browser/ui/search/search_ipc_router_policy_unittest.cc (right): https://codereview.chromium.org/24940002/diff/9001/chrome/browser/ui/search/search_ipc_router_policy_unittest.cc#newcode49 chrome/browser/ui/search/search_ipc_router_policy_unittest.cc:49: ASSERT_TRUE(search_tab_helper->ipc_router().policy()-> On 2013/10/01 17:41:55, Jered wrote: ...

7 years, 2 months ago (2013-10-01 18:33:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/24940002/23001

7 years, 2 months ago (2013-10-01 18:33:49 UTC) #4

Message was sent while issue was closed.

Change committed as 226346

Expand Messages | Collapse Messages