Display "Restart to update" dialog to Chrome OS users.

chrome/browser/component_updater/pepper_flash_component_installer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/pepper_flash_component_installer.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 26 matching lines @@
 #include "components/component_updater/default_component_installer.h"
 #include "components/update_client/update_client.h"
 #include "components/update_client/update_client_errors.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/plugin_service.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/pepper_plugin_info.h"
 #include "ppapi/shared_impl/ppapi_permissions.h"
 
 #if defined(OS_CHROMEOS)
+#include "chrome/browser/ui/ash/system_tray_delegate_chromeos.h"
 #include "chromeos/dbus/dbus_method_call_status.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/image_loader_client.h"
 #include "content/public/browser/browser_thread.h"
 #elif defined(OS_LINUX)
 #include "chrome/common/component_flash_hint_file_linux.h"
 #endif  // defined(OS_CHROMEOS)
 
 using content::BrowserThread;
 using content::PluginService;
 
 namespace component_updater {
 
 namespace {
 
 #if defined(GOOGLE_CHROME_BUILD)
 // CRX hash. The extension id is: mimojjlkmoijpicakmndhoigimigcmbb.
 const uint8_t kSha2Hash[] = {0xc8, 0xce, 0x99, 0xba, 0xce, 0x89, 0xf8, 0x20,
                              0xac, 0xd3, 0x7e, 0x86, 0x8c, 0x86, 0x2c, 0x11,
                              0xb9, 0x40, 0xc5, 0x55, 0xaf, 0x08, 0x63, 0x70,
                              0x54, 0xf9, 0x56, 0xd3, 0xe7, 0x88, 0xba, 0x8c};
 
 #if defined(OS_CHROMEOS)
 void LogRegistrationResult(chromeos::DBusMethodCallStatus call_status,
                            bool result) {

[waffles, 2016/11/17 00:39:56]

Maybe it's time to add a DCHECK_CURRENTLY_ON(content::BrowserThread::UI) here.

[Greg K, 2016/11/30 19:30:29]

Done.

   if (call_status != chromeos::DBUS_METHOD_CALL_SUCCESS) {
     LOG(ERROR) << "Call to imageloader service failed.";
     return;
   }
-  if (!result)
+  if (!result) {
     LOG(ERROR) << "Component flash registration failed";
+    return;
+  }
+  chromeos::SystemTrayDelegateChromeOS* tray =
+      chromeos::SystemTrayDelegateChromeOS::Get();
+  if (tray) {
+    tray->SetFlashUpdateAvailable();

[waffles, 2016/11/17 00:39:56]

As an FYI, the updater uses a lot of CONTINUE_ON_SHUTDOWN, so we can wind up
calling this pretty late in the browser's destruction. As long as this is only
run on the UI thread I think this should be safe.

[Greg K, 2016/11/30 19:30:29]

Acknowledged.

+  }
 }
 
 void ImageLoaderRegistration(const std::string& version,
                              const base::FilePath& install_dir) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   chromeos::ImageLoaderClient* loader =
       chromeos::DBusThreadManager::Get()->GetImageLoaderClient();
 
   if (loader) {
     loader->RegisterComponent("PepperFlashPlayer", version, install_dir.value(),
@@ skipping 221 matching lines @@
   std::unique_ptr<ComponentInstallerTraits> traits(
       new FlashComponentInstallerTraits);
   // |cus| will take ownership of |installer| during installer->Register(cus).
   DefaultComponentInstaller* installer =
       new DefaultComponentInstaller(std::move(traits));
   installer->Register(cus, base::Closure());
 #endif  // defined(GOOGLE_CHROME_BUILD)
 }
 
 }  // namespace component_updater