Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: tools/perf/benchmarks/v8.py

Issue 2493953002: Initial implementation of V8 Top 25 Runtime Stats benchmark (Closed)
Patch Set: Address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/data/v8_top_25.json » ('j') | tools/perf/page_sets/v8_top_25.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index 167c07a7603012ebdcb1d490395df86f471e3348..d36680e3d99c8019fdfdfd6a6f1eca241a0bd920 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -228,3 +228,52 @@ class V8Adword(perf_benchmark.PerfBenchmark):
@classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
return True
+
+
+class _Top25RuntimeStats(perf_benchmark.PerfBenchmark):
+ options = {'pageset_repeat': 1}
+
+ def CreateTimelineBasedMeasurementOptions(self):
+ cat_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter(
+ filter_string='blink.console,navigation,blink.user_timing,loading')
+
+ # Below categories are needed for first-meaningful-paint computation.
nednguyen 2016/11/11 00:06:09 You no longer need these two for FMP. Maybe just r
fmeawad 2016/11/11 01:06:08 Copied the loadingMetric version, and added a TODO
+ cat_filter.AddDisabledByDefault('disabled-by-default-blink.debug.layout')
+ cat_filter.AddIncludedCategory('devtools.timeline')
+
+ # Below categories are needed for time-to-interactive computation.
+ cat_filter.AddIncludedCategory('toplevel')
+
+ # V8 needed categories
+ cat_filter.AddIncludedCategory('v8')
+ cat_filter.AddDisabledByDefault('disabled-by-default-v8.runtime_stats')
+
+ tbm_options = timeline_based_measurement.Options(
+ overhead_level=cat_filter)
+ tbm_options.SetTimelineBasedMetrics(['runtimeStatsMetric'])
+ return tbm_options
+
+ @classmethod
+ def ShouldDisable(cls, possible_browser):
+ if possible_browser.browser_type == 'reference':
+ return True
+ return False
+
+ @classmethod
+ def ShouldTearDownStateAfterEachStoryRun(cls):
nednguyen 2016/11/11 00:06:09 You don't need to override this since it's True by
fmeawad 2016/11/11 01:06:09 Done.
+ return True
+
+
+class V8Top25RuntimeStats(_Top25RuntimeStats):
+ """Runtime Stats benchmark for a 25 top V8 web pages.
+
+ Designed to represent a mix between top websites and a set of pages that
+ have unique V8 characteristics.
+ """
+
+ @classmethod
+ def Name(cls):
+ return 'v8.runtime_stats.top_25'
+
+ def CreateStorySet(self, options):
+ return page_sets.V8Top25StorySet()
« no previous file with comments | « no previous file | tools/perf/page_sets/data/v8_top_25.json » ('j') | tools/perf/page_sets/v8_top_25.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698