[wasm] Make reported "lines" on stack frames 1-based

[wasm] Make reported "lines" on stack frames 1-based

In captured stack traces, all lines and columns must be 1-based.
Even though this makes things a bit ugly, we have to comply also for
wasm locations, where line and column encode function index and byte
offset (both are originally 0-based).

If we don't comply, the frontend might complain, as e.g. DevTools does.

BUG=chromium:659715
R=yangguo@chromium.org, kozyatinskiy@chromium.org
CC=titzer@chromium.org

Committed: https://crrev.com/0c6fa1724f3ae2642f2f1628c10c362e01078803
Cr-Commit-Position: refs/heads/master@{#40971}

[Clemens Hammacher, 2016-11-10 22:29:37]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 22:29:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 22:45:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 22:45:26]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Clemens Hammacher, 2016-11-10 22:52:06]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 22:52:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 23:18:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 23:18:42]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-11-11 02:27:09]

Description was changed from

==========
[wasm] Make reported "lines" on stack frames 1-based

In captured stack traces, all lines and columns must be 1-based.
Even though this makes things a bit ugly, we have to comply also for
wasm locations, where line and column encode function index and byte
offset (both are originally 0-based).

If we don't comply, the frontend (e.g. DevTools) will complain.

BUG=chromium:659715
R=yangguo@chromium.org, kozyatinskiy@chromium.org
CC=titzer@chromium.org
==========

to

==========
[wasm] Make reported "lines" on stack frames 1-based

In captured stack traces, all lines and columns must be 1-based.
Even though this makes things a bit ugly, we have to comply also for
wasm locations, where line and column encode function index and byte
offset (both are originally 0-based).

If we don't comply, the frontend might complain, as e.g. DevTools does.

BUG=chromium:659715
R=yangguo@chromium.org, kozyatinskiy@chromium.org
CC=titzer@chromium.org
==========

[kozy, 2016-11-11 03:28:51]

lgtm

[titzer, 2016-11-14 09:24:49]

On 2016/11/11 03:28:51, kozyatinskiy wrote:
> lgtm

lgtm

[Yang, 2016-11-14 10:49:52]

On 2016/11/14 09:24:49, titzer wrote:
> On 2016/11/11 03:28:51, kozyatinskiy wrote:
> > lgtm
> 
> lgtm

lgtm.

[Clemens Hammacher, 2016-11-14 15:19:51]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 15:19:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 15:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 15:44:32]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-11-14 15:55:41]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-11-14 15:55:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, titzer@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2493943002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-14 15:55:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 16:00:07]

Description was changed from

==========
[wasm] Make reported "lines" on stack frames 1-based

In captured stack traces, all lines and columns must be 1-based.
Even though this makes things a bit ugly, we have to comply also for
wasm locations, where line and column encode function index and byte
offset (both are originally 0-based).

If we don't comply, the frontend might complain, as e.g. DevTools does.

BUG=chromium:659715
R=yangguo@chromium.org, kozyatinskiy@chromium.org
CC=titzer@chromium.org
==========

to

==========
[wasm] Make reported "lines" on stack frames 1-based

In captured stack traces, all lines and columns must be 1-based.
Even though this makes things a bit ugly, we have to comply also for
wasm locations, where line and column encode function index and byte
offset (both are originally 0-based).

If we don't comply, the frontend might complain, as e.g. DevTools does.

BUG=chromium:659715
R=yangguo@chromium.org, kozyatinskiy@chromium.org
CC=titzer@chromium.org
==========

[commit-bot: I haz the power, 2016-11-14 16:00:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:32:56]

Description was changed from

==========
[wasm] Make reported "lines" on stack frames 1-based

In captured stack traces, all lines and columns must be 1-based.
Even though this makes things a bit ugly, we have to comply also for
wasm locations, where line and column encode function index and byte
offset (both are originally 0-based).

If we don't comply, the frontend might complain, as e.g. DevTools does.

BUG=chromium:659715
R=yangguo@chromium.org, kozyatinskiy@chromium.org
CC=titzer@chromium.org
==========

to

==========
[wasm] Make reported "lines" on stack frames 1-based

In captured stack traces, all lines and columns must be 1-based.
Even though this makes things a bit ugly, we have to comply also for
wasm locations, where line and column encode function index and byte
offset (both are originally 0-based).

If we don't comply, the frontend might complain, as e.g. DevTools does.

BUG=chromium:659715
R=yangguo@chromium.org, kozyatinskiy@chromium.org
CC=titzer@chromium.org

Committed: https://crrev.com/0c6fa1724f3ae2642f2f1628c10c362e01078803
Cr-Commit-Position: refs/heads/master@{#40971}
==========

[commit-bot: I haz the power, 2016-11-17 22:32:57]

Patchset 3 (id:??) landed as
https://crrev.com/0c6fa1724f3ae2642f2f1628c10c362e01078803
Cr-Commit-Position: refs/heads/master@{#40971}