Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2493903002: [chromedriver] Remove --disable-component-update switch (Closed)

Created:
4 years, 1 month ago by gmanikpure
Modified:
4 years, 1 month ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Remove --disable-component-update switch BUG=chromedriver:1578 Committed: https://crrev.com/1d9b7369a67d3a0a6ff2d629f97e0f3e4cd7dff4 Cr-Commit-Position: refs/heads/master@{#432627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
gmanikpure
Hi Sam, Removing this switch as it refrains flash content from loading on the page. ...
4 years, 1 month ago (2016-11-10 21:36:57 UTC) #2
samuong
lgtm
4 years, 1 month ago (2016-11-16 19:33:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493903002/1
4 years, 1 month ago (2016-11-16 20:22:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 21:08:33 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 21:13:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d9b7369a67d3a0a6ff2d629f97e0f3e4cd7dff4
Cr-Commit-Position: refs/heads/master@{#432627}

Powered by Google App Engine
This is Rietveld 408576698