Introduce Internals#replaceMisspelled() and Internals#setMarker()

third_party/WebKit/Source/core/testing/Internals.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 128 matching lines @@
 #include "platform/scroll/ProgrammaticScrollAnimator.h"
 #include "platform/testing/URLTestHelpers.h"
 #include "platform/tracing/TraceEvent.h"
 #include "platform/weborigin/SchemeRegistry.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebConnectionType.h"
 #include "public/platform/WebGraphicsContext3DProvider.h"
 #include "public/platform/WebLayer.h"
 #include "public/platform/modules/remoteplayback/WebRemotePlaybackAvailability.h"
 #include "wtf/InstanceCounter.h"
+#include "wtf/Optional.h"
 #include "wtf/PtrUtil.h"
 #include "wtf/dtoa.h"
 #include "wtf/text/StringBuffer.h"
 #include <deque>
 #include <memory>
 #include <v8.h>
 
 namespace blink {
 
 namespace {
 
 class InternalsIterationSource final
     : public ValueIterable<int>::IterationSource {
  public:
   bool next(ScriptState* scriptState,
             int& value,
             ExceptionState& exceptionState) override {
     if (m_index >= 5)
       return false;
     value = m_index * m_index;
     return true;
   }
 };
 
 }  // namespace
 
-static bool markerTypesFrom(const String& markerType,
-                            DocumentMarker::MarkerTypes& result) {
+static WTF::Optional<DocumentMarker::MarkerType> markerTypeFrom(
+    const String& markerType) {
+  if (equalIgnoringCase(markerType, "Spelling"))
+    return DocumentMarker::Spelling;
+  if (equalIgnoringCase(markerType, "Grammar"))
+    return DocumentMarker::Grammar;
+  if (equalIgnoringCase(markerType, "TextMatch"))
+    return DocumentMarker::TextMatch;
+

[yosin_UTC9, 2016/11/15 02:14:06]

nit: Please get rid of an extra blank line.

+  return WTF::nullopt;
+}
+
+static WTF::Optional<DocumentMarker::MarkerTypes> markerTypesFrom(
+    const String& markerType) {
   if (markerType.isEmpty() || equalIgnoringCase(markerType, "all"))
-    result = DocumentMarker::AllMarkers();
-  else if (equalIgnoringCase(markerType, "Spelling"))
-    result = DocumentMarker::Spelling;
-  else if (equalIgnoringCase(markerType, "Grammar"))
-    result = DocumentMarker::Grammar;
-  else if (equalIgnoringCase(markerType, "TextMatch"))
-    result = DocumentMarker::TextMatch;
-  else
-    return false;
+    return DocumentMarker::AllMarkers();
+  WTF::Optional<DocumentMarker::MarkerType> type = markerTypeFrom(markerType);
+  if (type)
+    return static_cast<DocumentMarker::MarkerTypes>(type.value());

[yosin_UTC9, 2016/11/15 02:14:06]

Can we use |DocumentMarker::MarkerTypes(type.value())|?

 
-  return true;
+  return WTF::nullopt;

[yosin_UTC9, 2016/11/15 02:14:06]

It is more readable switching if-condition:

if (!type)
  return WTF::nullopt;
return DocumentMarker::MarkerTypes(type.value());

 }
 
 static SpellCheckRequester* spellCheckRequester(Document* document) {
   if (!document || !document->frame())
     return 0;
   return &document->frame()->spellChecker().spellCheckRequester();
 }
 
 static ScrollableArea* scrollableAreaForNode(Node* node) {
   if (!node)
@@ skipping 707 matching lines @@
   ASSERT(element);
 
   element->document().updateStyleAndLayoutIgnorePendingStylesheets();
   LayoutObject* layoutObject = element->layoutObject();
   if (!layoutObject)
     return ClientRect::create();
   return ClientRect::create(
       layoutObject->absoluteBoundingBoxRectIgnoringTransforms());
 }
 
+void Internals::setMarker(Document* document,
+                          const Range* range,
+                          const String& markerType,
+                          ExceptionState& exceptionState) {
+  if (!document) {
+    exceptionState.throwDOMException(InvalidAccessError,
+                                     "No context document is available.");
+    return;
+  }
+
+  WTF::Optional<DocumentMarker::MarkerType> type = markerTypeFrom(markerType);
+  if (!type) {
+    exceptionState.throwDOMException(
+        SyntaxError,
+        "The marker type provided ('" + markerType + "') is invalid.");
+    return;
+  }
+
+  document->markers().addMarker(range->startPosition(), range->endPosition(),
+                                type.value());
+}
+
 unsigned Internals::markerCountForNode(Node* node,
                                        const String& markerType,
                                        ExceptionState& exceptionState) {
   ASSERT(node);
-  DocumentMarker::MarkerTypes markerTypes = 0;
-  if (!markerTypesFrom(markerType, markerTypes)) {
+  WTF::Optional<DocumentMarker::MarkerTypes> markerTypes =
+      markerTypesFrom(markerType);
+  if (!markerTypes) {
     exceptionState.throwDOMException(
         SyntaxError,
         "The marker type provided ('" + markerType + "') is invalid.");
     return 0;
   }
 
-  return node->document().markers().markersFor(node, markerTypes).size();
+  return node->document()
+      .markers()
+      .markersFor(node, markerTypes.value())
+      .size();
 }
 
 unsigned Internals::activeMarkerCountForNode(Node* node) {
   ASSERT(node);
 
   // Only TextMatch markers can be active.
   DocumentMarker::MarkerType markerType = DocumentMarker::TextMatch;
   DocumentMarkerVector markers =
       node->document().markers().markersFor(node, markerType);
 
   unsigned activeMarkerCount = 0;
   for (const auto& marker : markers) {
     if (marker->activeMatch())
       activeMarkerCount++;
   }
 
   return activeMarkerCount;
 }
 
 DocumentMarker* Internals::markerAt(Node* node,
                                     const String& markerType,
                                     unsigned index,
                                     ExceptionState& exceptionState) {
   ASSERT(node);
-  DocumentMarker::MarkerTypes markerTypes = 0;
-  if (!markerTypesFrom(markerType, markerTypes)) {
+  WTF::Optional<DocumentMarker::MarkerTypes> markerTypes =
+      markerTypesFrom(markerType);
+  if (!markerTypes) {
     exceptionState.throwDOMException(
         SyntaxError,
         "The marker type provided ('" + markerType + "') is invalid.");
     return 0;
   }
 
   DocumentMarkerVector markers =
-      node->document().markers().markersFor(node, markerTypes);
+      node->document().markers().markersFor(node, markerTypes.value());
   if (markers.size() <= index)
     return 0;
   return markers[index];
 }
 
 Range* Internals::markerRangeForNode(Node* node,
                                      const String& markerType,
                                      unsigned index,
                                      ExceptionState& exceptionState) {
   ASSERT(node);
@@ skipping 846 matching lines @@
         InvalidAccessError,
         "No frame can be obtained from the provided document.");
     return;
   }
 
   if (enabled !=
       contextDocument()->frame()->spellChecker().isSpellCheckingEnabled())
     contextDocument()->frame()->spellChecker().toggleSpellCheckingEnabled();
 }
 
+void Internals::replaceMisspelled(Document* document,
+                                  const String& replacement,
+                                  ExceptionState& exceptionState) {
+  if (!document || !document->frame()) {
+    exceptionState.throwDOMException(
+        InvalidAccessError,
+        "No frame can be obtained from the provided document.");
+    return;
+  }
+
+  document->updateStyleAndLayoutIgnorePendingStylesheets();
+  document->frame()->spellChecker().replaceMisspelledRange(replacement);
+}
+
 bool Internals::canHyphenate(const AtomicString& locale) {
   return LayoutLocale::valueOrDefault(LayoutLocale::get(locale))
       .getHyphenation();
 }
 
 void Internals::setMockHyphenation(const AtomicString& locale) {
   LayoutLocale::setHyphenationForTesting(locale, adoptRef(new MockHyphenation));
 }
 
 bool Internals::isOverwriteModeEnabled(Document* document) {
@@ skipping 1196 matching lines @@
     return ClientRect::create();
 
   return ClientRect::create(FloatRect(node->layoutObject()->visualRect()));
 }
 
 void Internals::crash() {
   CHECK(false) << "Intentional crash";
 }
 
 }  // namespace blink