Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(46)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks-2.html
Issue
2493833004
:
InitialColumnHeightFinder needs to take all expected rows into account. (Closed)
Patch Set: Code review
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-column-count-1-with-forced-break-2.html
third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks.html
third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks-2.html
third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks-2-expected.html
third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks-expected.html
third_party/WebKit/Source/core/layout/ColumnBalancer.h
third_party/WebKit/Source/core/layout/ColumnBalancer.cpp
third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h
third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks.html
('k') |
third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks-2-expected.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<p>The word "PASS" should be seen below.</p>
3
<div style="columns:3; column-gap:0; width:24em; line-height:20px; orphans:1; wi dows:1; background:yellow;">
4
<br>
5
<div>
6
<div style="columns:2; column-gap:0;">
7
<div style="height:1px;"></div>
8
<div style="break-before:column;"></div>
9
<div style="height:1px;"></div>
10
<div style="break-before:column;"></div>
11
<br><br><br><br>PASS
12
</div>
13
</div>
14
</div>
OLD
NEW
« no previous file with comments
|
« third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks.html
('k') |
third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks-2-expected.html »
('j') |
no next file with comments »
Issue 2493833004: InitialColumnHeightFinder needs to take all expected rows into account. (Closed)
Created 4 years, 1 month ago by mstensho (USE GERRIT)
Modified 4 years, 1 month ago
Reviewers: eae, szager1
Base URL:
Comments: 5
This is Rietveld
408576698