third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-column-count-1-with-forced-break-2.html - Issue 2493833004: InitialColumnHeightFinder needs to take all expected rows into account.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-column-count-1-with-forced-break-2.html

Issue 2493833004: InitialColumnHeightFinder needs to take all expected rows into account. (Closed)

Patch Set: Code review Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>There should be a green square below, and no red.</p>

	3 <div id="outer" style="columns:2; column-gap:0; width:20px; line-height:20px; ba ckground:red;">

	4 <div style="columns:1; column-gap:0; background:green;">

	5 <div><br></div>

	6 <div style="break-before:column;"><br></div>

	7 </div>

	8 </div>

	9 <script src="../../resources/testharness.js"></script>

	10 <script src="../../resources/testharnessreport.js"></script>

	11 <script>

	12 test(() => {

	13 var elm = document.getElementById("outer");

	14 assert_equals(elm.offsetHeight, 20);

	15 }, "Inner column count is 1");

	16 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks.html » ('j') | no next file with comments »