third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks.html - Issue 2493833004: InitialColumnHeightFinder needs to take all expected rows into account.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/nested-balanced-inner-with-many-breaks.html

Issue 2493833004: InitialColumnHeightFinder needs to take all expected rows into account. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>The word "PASS" should be seen below.</p>

	3 <div style="columns:3; column-gap:0; width:24em; line-height:20px; orphans:1; wi dows:1; background:yellow;">

	4 <br>

	5 <div>
	mstensho (USE GERRIT) 2016/11/10 21:06:51 The extra DIV here (and in the other tests) is nee The extra DIV here (and in the other tests) is needed to trick the relayoutChildren if pageLogicalHeightChanged in LayoutBlockFlow::layoutBlockFlow().
	6 <div style="columns:2; column-gap:0;">

	7 <div style="height:1px;"></div>

	8 <div style="break-before:column;"></div>

	9 <div style="height:1px;"></div>

	10 <div style="break-before:column;"></div>

	11 PASS

	12 </div>

	13 </div>

	14 </div>

OLD	NEW