Issue 2493833002: GN: Don't depend on dart_bootstrap if there is a usable prebuilt sdk

Issue 2493833002: GN: Don't depend on dart_bootstrap if there is a usable prebuilt sdk (Closed)

Created:
4 years, 1 month ago by zra

Modified:
4 years, 1 month ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't depend on dart_bootstrap if there is a usable prebuilt sdk Also replace invoke_dart() with compiled_action(), and some other cleanups. fixes #27781 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/90d3962ca3abd6270a33e9dfeb7a15ff8b475027

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -202 lines)			Patch
A +	build/executable_suffix.gni	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	build/gn_run_binary.py	View	1 chunk	+18 lines, -5 lines	0 comments	Download
A	build/prebuilt_dart_sdk.gni	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	runtime/observatory/BUILD.gn	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/BUILD.gn	View	3 chunks	+18 lines, -11 lines	0 comments	Download
D	tools/dart_for_gn.py	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	utils/analysis_server/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	utils/application_snapshot.gni	View	2 chunks	+4 lines, -43 lines	0 comments	Download
M	utils/compiler/BUILD.gn	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	utils/dartanalyzer/BUILD.gn	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	utils/dartdevc/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/dartdoc/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/dartfmt/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
D	utils/invoke_dart.gni	View	1 chunk	+0 lines, -90 lines	0 comments	Download
M	utils/pub/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (3 generated)

zra

4 years, 1 month ago (2016-11-10 19:16:29 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
90d3962ca3abd6270a33e9dfeb7a15ff8b475027 (presubmit successful).