[heap] Add basic infrastructure for Minor Mark-Compact collector

[heap] Add basic infrastructure for Minor Mark-Compact collector

BUG=chromium:651354
Committed: https://crrev.com/df5b86de4cc3115b849d3c40d12637ce39131ed7
Cr-Commit-Position: refs/heads/master@{#40935}

[Michael Lippautz, 2016-11-11 10:09:00]

Patchset #2 (id:20001) has been deleted

[Michael Lippautz, 2016-11-11 10:09:03]

Patchset #1 (id:1) has been deleted

[Michael Lippautz, 2016-11-11 10:09:23]

Description was changed from

==========
[heap] Add basic infrastructure for Minor Mark-Compact collector

BUG=chromium:651354
==========

to

==========
[heap] Add basic infrastructure for Minor Mark-Compact collector

BUG=chromium:651354
==========

[Michael Lippautz, 2016-11-11 10:09:23]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org, ulan@chromium.org

[Michael Lippautz, 2016-11-11 10:10:08]

ptal, next step is to add basic marking (non-incremental) and maybe a
verification mode hooking into the scavenger

[ulan, 2016-11-11 10:22:10]

lgtm

https://codereview.chromium.org/2493803002/diff/40001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/2493803002/diff/40001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:157: if (collector == SCAVENGER) {
Nit: use switch statement.

https://codereview.chromium.org/2493803002/diff/40001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:218: collector == SCAVENGER
Nit: maybe extract to a separate function.

[Michael Lippautz, 2016-11-11 10:38:22]

https://codereview.chromium.org/2493803002/diff/40001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/2493803002/diff/40001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:157: if (collector == SCAVENGER) {
On 2016/11/11 10:22:10, ulan wrote:
> Nit: use switch statement.

Done.

https://codereview.chromium.org/2493803002/diff/40001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:218: collector == SCAVENGER
On 2016/11/11 10:22:10, ulan wrote:
> Nit: maybe extract to a separate function.

Done.

[Hannes Payer (out of office), 2016-11-11 14:02:43]

lgtm

https://codereview.chromium.org/2493803002/diff/60001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/2493803002/diff/60001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:254: recorded_scavenges_total_.Push(
recorded_scavenges_total_ should change recorded_minor_gcs

[Michael Lippautz, 2016-11-11 15:11:00]

https://codereview.chromium.org/2493803002/diff/60001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/2493803002/diff/60001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:254: recorded_scavenges_total_.Push(
On 2016/11/11 14:02:42, Hannes Payer wrote:
> recorded_scavenges_total_ should change recorded_minor_gcs

Done.

[Michael Lippautz, 2016-11-11 15:11:05]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 15:11:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 15:37:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 15:37:58]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-11-11 15:46:19]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-11-11 15:46:19]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org,
hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2493803002/#ps80001
(title: "Addressed comment")

[commit-bot: I haz the power, 2016-11-11 15:46:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 15:48:27]

Description was changed from

==========
[heap] Add basic infrastructure for Minor Mark-Compact collector

BUG=chromium:651354
==========

to

==========
[heap] Add basic infrastructure for Minor Mark-Compact collector

BUG=chromium:651354
==========

[commit-bot: I haz the power, 2016-11-11 15:48:28]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-11-17 22:31:08]

Description was changed from

==========
[heap] Add basic infrastructure for Minor Mark-Compact collector

BUG=chromium:651354
==========

to

==========
[heap] Add basic infrastructure for Minor Mark-Compact collector

BUG=chromium:651354

Committed: https://crrev.com/df5b86de4cc3115b849d3c40d12637ce39131ed7
Cr-Commit-Position: refs/heads/master@{#40935}
==========

[commit-bot: I haz the power, 2016-11-17 22:31:09]

Patchset 3 (id:??) landed as
https://crrev.com/df5b86de4cc3115b849d3c40d12637ce39131ed7
Cr-Commit-Position: refs/heads/master@{#40935}