Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: pkg/analyzer/lib/src/dart/analysis/byte_store.dart

Issue 2493793002: Fix and test for MemoryCachingByteStore. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/dart/analysis/byte_store_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/analysis/byte_store.dart
diff --git a/pkg/analyzer/lib/src/dart/analysis/byte_store.dart b/pkg/analyzer/lib/src/dart/analysis/byte_store.dart
index 681ee25831abdf99a900f7f982ee529accd3f98a..ab8e8ed01625a8136f9922404b35a9c78e82b15c 100644
--- a/pkg/analyzer/lib/src/dart/analysis/byte_store.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/byte_store.dart
@@ -43,12 +43,14 @@ class MemoryCachingByteStore implements ByteStore {
@override
List<int> get(String key) {
- List<int> bytes = _map[key];
+ List<int> bytes = _map.remove(key);
if (bytes == null) {
bytes = _store.get(key);
_map[key] = bytes;
_currentSizeBytes += bytes?.length ?? 0;
_evict();
+ } else {
+ _map[key] = bytes;
}
return bytes;
}
« no previous file with comments | « no previous file | pkg/analyzer/test/src/dart/analysis/byte_store_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698