Issue 249373003: Revert of eliminate config param -- it was always self's config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 249373003: Revert of eliminate config param -- it was always self's config (Closed)

Created:
6 years, 8 months ago by bsalomon

Modified:
6 years, 8 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/) Reason for revert: Causes some layout_test failures around texture backed bitmaps. Test names and crash logs accessible via: https://storage.googleapis.com/chromium-layout-test-archives/linux_layout/13845/layout-test-results/results.html Original issue's description: > eliminate config param -- it was always self's config > > BUG=skia: > R=bsalomon@google.com > > Committed: https://code.google.com/p/skia/source/detail?r=14303 TBR=reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14324

Created: 6 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -14 lines)			Patch
M	include/core/SkPixelRef.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	include/gpu/SkGrPixelRef.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkBitmap.cpp	View	3 chunks	+18 lines, -8 lines	0 comments	Download
M	src/gpu/SkGrPixelRef.cpp	View	4 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

bsalomon

Created Revert of eliminate config param -- it was always self's config

6 years, 8 months ago (2014-04-23 14:51:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/249373003/1

6 years, 8 months ago (2014-04-23 14:51:58 UTC) #2

Message was sent while issue was closed.

Change committed as 14324