Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: src/inspector/v8-debugger-agent-impl.cc

Issue 2493723003: [inspector] Fix and refactor String16 (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/inspector/string-16.h ('K') | « src/inspector/string-16.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger-agent-impl.cc
diff --git a/src/inspector/v8-debugger-agent-impl.cc b/src/inspector/v8-debugger-agent-impl.cc
index ab4e349909865e93c5c2ecc23f888dd16a45e6da..ae7cad284588e9a822112d8a310963f870e301e5 100644
--- a/src/inspector/v8-debugger-agent-impl.cc
+++ b/src/inspector/v8-debugger-agent-impl.cc
@@ -76,8 +76,8 @@ static String16 breakpointIdSuffix(
static String16 generateBreakpointId(
const String16& scriptId, int lineNumber, int columnNumber,
V8DebuggerAgentImpl::BreakpointSource source) {
- return scriptId + ":" + String16::fromInteger(lineNumber) + ":" +
- String16::fromInteger(columnNumber) + breakpointIdSuffix(source);
+ return String16::concat(scriptId, ':', lineNumber, ':', columnNumber,
+ breakpointIdSuffix(source));
}
static bool positionComparator(const std::pair<int, int>& a,
« src/inspector/string-16.h ('K') | « src/inspector/string-16.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698