Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2493703004: Support extending TemplateElement in IE11 + webcomponents-lite.js (Closed)

Created:
4 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
4 years, 1 month ago
Reviewers:
jakemac, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support extending TemplateElement in IE11 + webcomponents-lite.js Addresses issue reported in the polymer repo: https://github.com/dart-lang/polymer-dart/issues/682 R=jakemac@google.com, sra@google.com Committed: https://github.com/dart-lang/sdk/commit/008da86c0339a78b30e547c4c0f6547a68ac903f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -4 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +5 lines, -2 lines 0 comments Download
A tests/html/custom/document_register_template_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A tests/html/custom/document_register_template_test.html View 1 chunk +22 lines, -0 lines 0 comments Download
M tools/dom/src/dart2js_CustomElementSupport.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Siggi Cherem (dart-lang)
4 years, 1 month ago (2016-11-12 00:41:26 UTC) #4
sra1
lgtm
4 years, 1 month ago (2016-11-12 00:47:23 UTC) #5
jakemac
lgtm
4 years, 1 month ago (2016-11-12 01:04:47 UTC) #6
Siggi Cherem (dart-lang)
4 years, 1 month ago (2016-11-14 15:32:18 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:40001) manually as
008da86c0339a78b30e547c4c0f6547a68ac903f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698