Make "compositionend" event fired after setting caret position

third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/InputMethodController.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/Range.h"
 #include "core/editing/Editor.h"
@@ skipping 834 matching lines @@
       "<div id='sample' contentEditable='true'></div>", "sample");
   Element* script = document().createElement("script", ASSERT_NO_EXCEPTION);
   script->setInnerHTML(
       "document.getElementById('sample').addEventListener('beforeinput', "
       "function(event) {"
       "    document.title = `beforeinput.data:${event.data};`;"
       "});"
       "document.getElementById('sample').addEventListener('input', "
       "function(event) {"
       "    document.title += `input.data:${event.data};`;"
+      "});"
+      "document.getElementById('sample').addEventListener('compositionend', "
+      "function(event) {"
+      "    if (getSelection().anchorOffset != event.data.length)"

[yosin_UTC9, 2016/11/11 04:17:46]

nit: We should have {} for then-clause.

+      "        document.title += 'Wrong selection! Expected ' "

[yosin_UTC9, 2016/11/11 04:17:46]

Can we have a test case for this?

BTW, I don't think it is wrong selection. Since, caller can specify caret
position other than end.

[yabinh, 2016/11/11 05:23:52]

How about this: 
document.title += `selectionOffset:${getSelection().anchorOffset};`;
Thus, we don't need additional test case.

+      "                       + event.data.length + ', but got '"
+      "                       + getSelection().anchorOffset + '!';"
+      "    document.title += `compositionend.data:${event.data};`;"
       "});",
       ASSERT_NO_EXCEPTION);
   document().body()->appendChild(script, ASSERT_NO_EXCEPTION);
   document().view()->updateAllLifecyclePhases();
 
   // Simulate composition in the |contentEditable|.
   Vector<CompositionUnderline> underlines;
   underlines.append(CompositionUnderline(0, 5, Color(255, 0, 0), false, 0));
   editable->focus();
 
+  // Create new composition.
   document().setTitle(emptyString());
+  controller().setComposition("n", underlines, 1, 1);
+  EXPECT_STREQ("beforeinput.data:n;input.data:n;",
+               document().title().utf8().data());
+
+  // Update the existing composition.
+  // TODO(yabinh): should be "beforeinput.data:ni;input.data:ni;".
+  document().setTitle(emptyString());
+  controller().setComposition("ni", underlines, 2, 2);
+  EXPECT_STREQ("beforeinput.data:i;input.data:i;",
+               document().title().utf8().data());
+
+  // Confirm the ongoing composition.
+  document().setTitle(emptyString());
+  controller().finishComposingText(InputMethodController::KeepSelection);
+  EXPECT_STREQ("beforeinput.data:ni;input.data:ni;compositionend.data:ni;",
+               document().title().utf8().data());
+
+  // Delete the existing composition.
+  document().setTitle(emptyString());
+  document().updateStyleAndLayout();
+  controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+  controller().setComposition("n", underlines, 1, 1);
+  EXPECT_STREQ("beforeinput.data:n;input.data:n;",
+               document().title().utf8().data());
+  document().setTitle(emptyString());
+  controller().setComposition("", underlines, 0, 0);
+  EXPECT_STREQ("beforeinput.data:;compositionend.data:;",
+               document().title().utf8().data());
+
+  // Insert new text without previous composition.
+  document().setTitle(emptyString());
+  controller().commitText("hello", 0);
+  EXPECT_STREQ("beforeinput.data:hello;input.data:hello;",
+               document().title().utf8().data());
+
+  // Insert new text with previous composition.
+  document().setTitle(emptyString());
+  document().updateStyleAndLayout();
+  controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
   controller().setComposition("n", underlines, 0, 1);
   EXPECT_STREQ("beforeinput.data:n;input.data:n;",
                document().title().utf8().data());
-
   document().setTitle(emptyString());
-  controller().setComposition("ni", underlines, 0, 1);
-  EXPECT_STREQ("beforeinput.data:i;input.data:i;",
-               document().title().utf8().data());
-
-  document().setTitle(emptyString());
-  controller().finishComposingText(InputMethodController::KeepSelection);
-  EXPECT_STREQ("beforeinput.data:ni;input.data:ni;",
+  controller().commitText("abc", 0);
+  EXPECT_STREQ("beforeinput.data:abc;input.data:abc;compositionend.data:abc;",
                document().title().utf8().data());
 }
 
 }  // namespace blink