Make "compositionend" event fired after setting caret position

third_party/WebKit/Source/core/editing/InputMethodController.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 205 matching lines @@
 
 bool InputMethodController::finishComposingText(
     ConfirmCompositionBehavior confirmBehavior) {
   if (!hasComposition())
     return false;
 
   if (confirmBehavior == KeepSelection) {
     PlainTextRange oldOffsets = getSelectionOffsets();
     Editor::RevealSelectionScope revealSelectionScope(&editor());
 
-    bool result = replaceComposition(composingText());
+    const String& composing = composingText();
+    const bool result = replaceComposition(composing);
 
     // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
     // needs to be audited. see http://crbug.com/590369 for more details.
     document().updateStyleAndLayoutIgnorePendingStylesheets();
 
     setSelectionOffsets(oldOffsets);
+
+    // No DOM update after 'compositionend'.
+    dispatchCompositionEndEvent(frame(), composing);
+
     return result;
   }
 
   return replaceCompositionAndMoveCaret(composingText(), 0);
 }
 
 bool InputMethodController::commitText(const String& text,
                                        int relativeCaretPosition) {
   if (hasComposition())
     return replaceCompositionAndMoveCaret(text, relativeCaretPosition);
@@ skipping 36 matching lines @@
 
   clear();
 
   insertTextDuringCompositionWithEvents(
       frame(), text, 0,
       TypingCommand::TextCompositionType::TextCompositionConfirm);
   // Event handler might destroy document.
   if (!isAvailable())
     return false;
 
-  // No DOM update after 'compositionend'.
-  dispatchCompositionEndEvent(frame(), text);
-
   return true;
 }
 
 // relativeCaretPosition is relative to the end of the text.
 static int computeAbsoluteCaretPosition(size_t textStart,
                                         size_t textLength,
                                         int relativeCaretPosition) {
   return textStart + textLength + relativeCaretPosition;
 }
 
 bool InputMethodController::replaceCompositionAndMoveCaret(
     const String& text,
     int relativeCaretPosition) {
   Element* rootEditableElement = frame().selection().rootEditableElement();
   if (!rootEditableElement)
     return false;
   PlainTextRange compositionRange =
       PlainTextRange::create(*rootEditableElement, *m_compositionRange);
   if (compositionRange.isNull())
     return false;
   int textStart = compositionRange.start();
 
   if (!replaceComposition(text))
     return false;
 
   int absoluteCaretPosition = computeAbsoluteCaretPosition(
       textStart, text.length(), relativeCaretPosition);
-  return moveCaret(absoluteCaretPosition);
+  if (!moveCaret(absoluteCaretPosition))
+    return false;
+
+  // No DOM update after 'compositionend'.
+  dispatchCompositionEndEvent(frame(), text);
+
+  return true;
 }
 
 bool InputMethodController::insertText(const String& text) {
   if (dispatchBeforeInputInsertText(document().focusedElement(), text) !=
       DispatchEventResult::NotCanceled)
     return false;
   editor().insertText(text, 0);
   return true;
 }
 
@@ skipping 290 matching lines @@
       // we simply delete selection without sending extra events.
       TypingCommand::deleteSelection(document(),
                                      TypingCommand::PreventSpellChecking);
     }
 
     // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
     // needs to be audited. see http://crbug.com/590369 for more details.
     document().updateStyleAndLayoutIgnorePendingStylesheets();
 
     setEditableSelectionOffsets(selectedRange);
-    return;
+
+    // No DOM update after 'compositionend'.
+    return dispatchCompositionEndEvent(frame(), text);

[aelias_OOO_until_Jul13, 2017/01/27 02:23:40]

This was reverted due to http://crbug.com/674295.  Not sure we want to reland
(rather we might change the spec to match the reality that implementations rely
on current ordering), but if we ever do, note that this change here is also
incorrect.  It should be in "if (hasComposition())" block, because otherwise
it's sending a CompositionEnd without a corresponding CompositionBegin.

   }
 
   // We should send a 'compositionstart' event only when the given text is not
   // empty because this function doesn't create a composition node when the text
   // is empty.
   if (!hasComposition()) {
     target->dispatchEvent(
         CompositionEvent::create(EventTypeNames::compositionstart,
                                  frame().domWindow(), frame().selectedText()));
     if (!isAvailable())
@@ skipping 531 matching lines @@
 
   return WebTextInputTypeNone;
 }
 
 DEFINE_TRACE(InputMethodController) {
   visitor->trace(m_frame);
   visitor->trace(m_compositionRange);
 }
 
 }  // namespace blink