Make "compositionend" event fired after setting caret position

third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/InputMethodController.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/Range.h"
 #include "core/editing/Editor.h"
@@ skipping 793 matching lines @@
   EXPECT_EQ(3u, controller().getSelectionOffsets().end());
 }
 
 TEST_F(InputMethodControllerTest, CompositionInputEventIsComposing) {
   document().settings()->setScriptEnabled(true);
   Element* editable = insertHTMLElement(
       "<div id='sample' contentEditable='true'></div>", "sample");
   Element* script = document().createElement("script", ASSERT_NO_EXCEPTION);
   script->setInnerHTML(
       "document.getElementById('sample').addEventListener('beforeinput', "
-      "function(event) {"
+      "event => {"
       "    document.title = `beforeinput.isComposing:${event.isComposing};`;"
       "});"
       "document.getElementById('sample').addEventListener('input', "
-      "function(event) {"
+      "event => {"
       "    document.title += `input.isComposing:${event.isComposing};`;"
       "});",
       ASSERT_NO_EXCEPTION);
   document().body()->appendChild(script, ASSERT_NO_EXCEPTION);
   document().view()->updateAllLifecyclePhases();
 
   // Simulate composition in the |contentEditable|.
   Vector<CompositionUnderline> underlines;
   underlines.append(CompositionUnderline(0, 5, Color(255, 0, 0), false, 0));
   editable->focus();
 
   document().setTitle(emptyString());
   controller().setComposition("foo", underlines, 0, 3);
   EXPECT_STREQ("beforeinput.isComposing:true;input.isComposing:true;",
                document().title().utf8().data());
 
   document().setTitle(emptyString());
   controller().finishComposingText(InputMethodController::KeepSelection);
   // Last pair of InputEvent should also be inside composition scope.
   EXPECT_STREQ("beforeinput.isComposing:true;input.isComposing:true;",
                document().title().utf8().data());
 }
 
 TEST_F(InputMethodControllerTest, CompositionInputEventData) {

[yosin_UTC9, 2016/11/16 02:02:10]

This test case is too long and it is hard to use for debugging since each step
depend on previous step.
We should break out them into individual tests for ease of narrowing failure
cause, e.g.

TEST_F(IMCTest, CompositionEndForDelete)
TEST_F(IMCTest, CompositionEndForInsert)
TEST_F(IMCTest, CompositionEndForReplace)
TEST_F(IMCTest, BeforeInputForDelete)
TEST_F(IMCTest, BeforeInputForInsert)
TEST_F(IMCTest, BeforeInputForReplace)

[yabinh, 2016/11/16 19:52:15]

Done.

   document().settings()->setScriptEnabled(true);
   Element* editable = insertHTMLElement(
       "<div id='sample' contentEditable='true'></div>", "sample");
   Element* script = document().createElement("script", ASSERT_NO_EXCEPTION);
   script->setInnerHTML(
       "document.getElementById('sample').addEventListener('beforeinput', "
-      "function(event) {"
+      "event => {"
       "    document.title = `beforeinput.data:${event.data};`;"
       "});"
       "document.getElementById('sample').addEventListener('input', "
-      "function(event) {"
+      "event => {"
       "    document.title += `input.data:${event.data};`;"
+      "});"
+      "document.getElementById('sample').addEventListener('compositionend', "
+      "event => {"
+      "    document.title += `compositionend.data:${event.data};`;"
+      // Reset the selection to [3,3] on receiving 'compositonend' event.
+      "    const node = document.getElementById('sample').firstChild;"
+      "    getSelection().collapse(node, 3);"

[yosin_UTC9, 2016/11/16 02:02:10]

Could you add two more tests which set selection 
 - range, e.g. 2,5
 - none, getSelection().removeAllRange()

[yabinh, 2016/11/16 19:52:15]

Done.

       "});",
       ASSERT_NO_EXCEPTION);
   document().body()->appendChild(script, ASSERT_NO_EXCEPTION);
   document().view()->updateAllLifecyclePhases();
 
   // Simulate composition in the |contentEditable|.
   Vector<CompositionUnderline> underlines;
   underlines.append(CompositionUnderline(0, 5, Color(255, 0, 0), false, 0));
   editable->focus();
 
+  // Create new composition.
   document().setTitle(emptyString());
-  controller().setComposition("n", underlines, 0, 1);
+  controller().setComposition("hell", underlines, 4, 4);
+  EXPECT_STREQ("beforeinput.data:hell;input.data:hell;",
+               document().title().utf8().data());
+
+  // Update the existing composition.
+  // TODO(yabinh): should be "beforeinput.data:hello;input.data:hello;".
+  document().setTitle(emptyString());
+  controller().setComposition("hello", underlines, 0, 0);
+  EXPECT_STREQ("beforeinput.data:o;input.data:o;",
+               document().title().utf8().data());
+
+  // Confirm the ongoing composition.
+  document().setTitle(emptyString());
+  // Move the caret to the end of text.
+  controller().finishComposingText(InputMethodController::DoNotKeepSelection);
+  EXPECT_STREQ(
+      "beforeinput.data:hello;input.data:hello;compositionend.data:hello;",
+      document().title().utf8().data());
+  document().updateStyleAndLayout();
+  // Caret has been reseted to [3,3] in 'compositionend' event listener.
+  EXPECT_EQ(3u, controller().getSelectionOffsets().start());
+  EXPECT_EQ(3u, controller().getSelectionOffsets().end());
+
+  // Delete the existing composition.
+  document().setTitle(emptyString());
+  controller().setComposition("hello", underlines, 5, 5);
+  EXPECT_STREQ("beforeinput.data:hello;input.data:hello;",
+               document().title().utf8().data());
+  document().setTitle(emptyString());
+  controller().setComposition("", underlines, 0, 0);
+  EXPECT_STREQ("beforeinput.data:;compositionend.data:;",
+               document().title().utf8().data());
+  document().updateStyleAndLayout();
+  EXPECT_EQ(3u, controller().getSelectionOffsets().start());
+  EXPECT_EQ(3u, controller().getSelectionOffsets().end());
+
+  // Insert new text without previous composition.
+  document().setTitle(emptyString());
+  controller().commitText("hello", 0);
+  EXPECT_STREQ("beforeinput.data:hello;input.data:hello;",
+               document().title().utf8().data());
+
+  // Insert new text with previous composition.
+  document().setTitle(emptyString());
+  controller().setComposition("n", underlines, 1, 1);
   EXPECT_STREQ("beforeinput.data:n;input.data:n;",
                document().title().utf8().data());
-
   document().setTitle(emptyString());
-  controller().setComposition("ni", underlines, 0, 1);
-  EXPECT_STREQ("beforeinput.data:i;input.data:i;",
-               document().title().utf8().data());
-
-  document().setTitle(emptyString());
-  controller().finishComposingText(InputMethodController::KeepSelection);
-  EXPECT_STREQ("beforeinput.data:ni;input.data:ni;",
-               document().title().utf8().data());
+  // Move the caret before "o".
+  controller().commitText("hello", -1);
+  EXPECT_STREQ(
+      "beforeinput.data:hello;input.data:hello;compositionend.data:hello;",
+      document().title().utf8().data());
+  document().updateStyleAndLayout();
+  // Caret has been reseted to [3,3] in 'compositionend' event listener.
+  EXPECT_EQ(3u, controller().getSelectionOffsets().start());
+  EXPECT_EQ(3u, controller().getSelectionOffsets().end());
 }
 
 }  // namespace blink