Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2493683002: [OfflinePages] Fixes RequestCoordinator bug not clearing state on timeout (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index 575c77136aa0baaa5ac734d06c661b06f47f9793..aa2d910c0836c37d1ecf4e44686b12b24d393fc6 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -1096,6 +1096,7 @@ TEST_F(RequestCoordinatorTest, WatchdogTimeoutForScheduledProcessing) {
PumpLoop();
EXPECT_FALSE(is_starting());
+ EXPECT_FALSE(coordinator()->is_busy());
EXPECT_TRUE(OfflinerWasCanceled());
}
@@ -1132,6 +1133,7 @@ TEST_F(RequestCoordinatorTest, WatchdogTimeoutForImmediateProcessing) {
PumpLoop();
// Verify the request timed out.
+ EXPECT_FALSE(coordinator()->is_busy());
EXPECT_TRUE(OfflinerWasCanceled());
}

Powered by Google App Engine
This is Rietveld 408576698