Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2493663002: Adds views_aura_mus_unittests to chromeos fyi bot (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds views_aura_mus_unittests to chromeos fyi bot BUG=660994 TEST=covered by tests R=msw@chromium.org Committed: https://crrev.com/c30d7ebd03947cacf84d7a17ad247f1ef22cec3a Cr-Commit-Position: refs/heads/master@{#431193}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fyi #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 1 chunk +6 lines, -0 lines 6 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
sky
4 years, 1 month ago (2016-11-09 23:56:20 UTC) #1
msw
https://codereview.chromium.org/2493663002/diff/1/testing/buildbot/chromium.chromiumos.json File testing/buildbot/chromium.chromiumos.json (right): https://codereview.chromium.org/2493663002/diff/1/testing/buildbot/chromium.chromiumos.json#newcode7 testing/buildbot/chromium.chromiumos.json:7: "Linux ChromiumOS Ozone Tests (1)": { Are these the ...
4 years, 1 month ago (2016-11-10 00:05:27 UTC) #2
sky
You are absolutely right. Updated.
4 years, 1 month ago (2016-11-10 00:38:29 UTC) #3
msw
Ignore all my comments, I can try to follow up separately. https://codereview.chromium.org/2493663002/diff/20001/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): ...
4 years, 1 month ago (2016-11-10 01:23:10 UTC) #4
msw
lgtm
4 years, 1 month ago (2016-11-10 01:23:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493663002/20001
4 years, 1 month ago (2016-11-10 03:40:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 06:05:38 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 06:09:25 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c30d7ebd03947cacf84d7a17ad247f1ef22cec3a
Cr-Commit-Position: refs/heads/master@{#431193}

Powered by Google App Engine
This is Rietveld 408576698