Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2493643002: Enable 'gn check' for //media/cast (Closed)

Created:
4 years, 1 month ago by Wez
Modified:
4 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable 'gn check' for //media/cast BUG=609355 Committed: https://crrev.com/e25ca8400bf8611c5f7733e6621c6dd9987ed922 Cr-Commit-Position: refs/heads/master@{#431460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M .gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Wez
PTAL - just enables gn check for //media/cast/* \o/
4 years, 1 month ago (2016-11-09 23:41:38 UTC) #4
brettw
Yay, lgtm
4 years, 1 month ago (2016-11-10 22:55:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493643002/1
4 years, 1 month ago (2016-11-10 23:16:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/161826)
4 years, 1 month ago (2016-11-11 00:00:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493643002/1
4 years, 1 month ago (2016-11-11 00:28:34 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 02:05:40 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 02:14:28 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e25ca8400bf8611c5f7733e6621c6dd9987ed922
Cr-Commit-Position: refs/heads/master@{#431460}

Powered by Google App Engine
This is Rietveld 408576698