Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2493633002: Add early returns in CJBig2_TRDProc::decode_Arith when decode fails. (Closed)

Created:
4 years, 1 month ago by npm
Modified:
4 years, 1 month ago
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add early returns in CJBig2_TRDProc::decode_Arith when decode fails. None of the decodes in the method are currently being checked. This is causing pdfium to take a long time rendering corrupted files. Thus, I added a couple of early returns to help prevent this from happening. BUG=450971 Committed: https://pdfium.googlesource.com/pdfium/+/3f8cb532c93bd2839073ed4949d051245de5a4cb

Patch Set 1 #

Patch Set 2 : Woops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M core/fxcodec/jbig2/JBig2_TrdProc.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
npm
PTAL
4 years, 1 month ago (2016-11-09 23:27:31 UTC) #5
Lei Zhang
lgtm
4 years, 1 month ago (2016-11-10 00:44:35 UTC) #8
dsinclair
lgtm
4 years, 1 month ago (2016-11-10 01:16:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493633002/20001
4 years, 1 month ago (2016-11-10 01:16:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493633002/20001
4 years, 1 month ago (2016-11-10 01:16:53 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 01:26:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/3f8cb532c93bd2839073ed4949d051245de5...

Powered by Google App Engine
This is Rietveld 408576698