Issue 249363002: Use macros instead of specializing VectorTraits explicitly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 249363002: Use macros instead of specializing VectorTraits explicitly (Closed)

Created:
6 years, 8 months ago by Mikhail

Modified:
6 years, 8 months ago

Reviewers:
eseidel

CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, ojan, caseq+blink_chromium.org, malch+blink_chromium.org, rwlbuis, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, devtools-reviews_chromium.org, rune+blink, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, Inactive, Mikhail, eseidel

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use macros instead of specializing VectorTraits explicitly The existing 'WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS' or the newly added 'WTF_ALLOW_MOVE_AND_INIT_WITH_MEM_FUNCTIONS' macros should be used instead of specializing VectorTraits explicitly, in order to improve code readability and decrease the number of LOC used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172381

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -66 lines)			Patch
M	Source/core/css/CSSGradientValue.h	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	Source/core/css/CSSProperty.h	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	Source/core/css/CSSPropertySourceData.h	View	1 chunk	+2 lines, -13 lines	0 comments	Download
M	Source/core/css/ElementRuleCollector.h	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	Source/core/css/RuleSet.h	View	1 chunk	+2 lines, -13 lines	0 comments	Download
M	Source/core/html/FormDataList.h	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	Source/core/inspector/InspectorStyleSheet.h	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	Source/wtf/VectorTraits.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/wtf/text/WTFString.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/249363002/1

6 years, 8 months ago (2014-04-23 15:25:36 UTC) #3

Message was sent while issue was closed.

Change committed as 172381

Expand Messages | Collapse Messages