Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 2493573003: DevTools: improve launch chrome (add --reset-profile option) (Closed)

Created:
4 years, 1 month ago by chenwilliam
Modified:
4 years, 1 month ago
Reviewers:
paulirish, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: improve launch chrome (add --reset-profile option) - by default, re-use the same dev profile for user-data-dir unless user wants to clear their dev profile by using "--reset-profile" - better support for looking up chromium on Linux - enables devtools experiment flag (for the built-in DevTools) BUG=629914 Committed: https://crrev.com/fdd431e08a4729eac09d876d988b9534a670a65b Cr-Commit-Position: refs/heads/master@{#431325}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -19 lines) Patch
M third_party/WebKit/Source/devtools/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/readme.md View 1 chunk +9 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js View 4 chunks +36 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/start_chrome_and_server.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
chenwilliam
PTAL. Improves the hosted mode workflow for launching chrome based on feedback from team members.
4 years, 1 month ago (2016-11-09 22:54:20 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2493573003/diff/1/third_party/WebKit/Source/devtools/readme.md File third_party/WebKit/Source/devtools/readme.md (right): https://codereview.chromium.org/2493573003/diff/1/third_party/WebKit/Source/devtools/readme.md#newcode40 third_party/WebKit/Source/devtools/readme.md:40: > npm run chrome -- --reset-profile Why extra ...
4 years, 1 month ago (2016-11-09 23:34:39 UTC) #3
chenwilliam
https://codereview.chromium.org/2493573003/diff/1/third_party/WebKit/Source/devtools/readme.md File third_party/WebKit/Source/devtools/readme.md (right): https://codereview.chromium.org/2493573003/diff/1/third_party/WebKit/Source/devtools/readme.md#newcode40 third_party/WebKit/Source/devtools/readme.md:40: > npm run chrome -- --reset-profile On 2016/11/09 23:34:39, ...
4 years, 1 month ago (2016-11-09 23:48:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493573003/1
4 years, 1 month ago (2016-11-10 18:32:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 19:55:41 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 20:10:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdd431e08a4729eac09d876d988b9534a670a65b
Cr-Commit-Position: refs/heads/master@{#431325}

Powered by Google App Engine
This is Rietveld 408576698