chrome/browser/sessions/session_common_utils.h - Issue 2493573002: Make sure that the browser will always restore settings page instead of sign out page after user si…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/sessions/session_common_utils.h

Issue 2493573002: Make sure that the browser will always restore settings page instead of sign out page after user si… (Closed)

Patch Set: append the missing file Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/people_page/people_page.js ('K') | « chrome/browser/resources/settings/people_page/people_page.js ('k') | chrome/browser/sessions/session_common_utils.cc » ('j') | chrome/browser/sessions/session_common_utils.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_SESSIONS_SESSION_COMMON_UTILS_H_	5 #ifndef CHROME_BROWSER_SESSIONS_SESSION_COMMON_UTILS_H_

6 #define CHROME_BROWSER_SESSIONS_SESSION_COMMON_UTILS_H_	6 #define CHROME_BROWSER_SESSIONS_SESSION_COMMON_UTILS_H_

7	7

	8 namespace sessions {

	9 struct SessionTab;

	10 } // namespace sessions

	11

8 class GURL;	12 class GURL;

9	13

10 // Returns whether sessions code should track a URL for restoring in the context	14 // Returns whether sessions code should track a URL for restoring in the context

11 // of //chrome. In particular, blacklists chrome://quit and chrome://restart to	15 // of //chrome. In particular, blacklists chrome://quit and chrome://restart to

12 // avoid quit or restart loops.	16 // avoid quit or restart loops.

13 bool ShouldTrackURLForRestore(const GURL& url);	17 bool ShouldTrackURLForRestore(const GURL& url);

14	18

	19 // Returns the current navigation index from the tab. If current navigation's

	20 // url is the sign out page and the url of previous one is the setting page,

	21 // returns the index of previous one.

	22 int GetSelectedIndexFromTab(const sessions::SessionTab& tab);
	sky 2016/11/11 00:32:17 Selected-index is rather generic in this case. How Selected-index is rather generic in this case. How about GetNavigationIndexToSelect? zmin 2016/11/11 22:54:01 Done. Show quoted text On 2016/11/11 00:32:17, sky wrote: > Selected-index is rather generic in this case. How about > GetNavigationIndexToSelect? Done.
	23

15 #endif // CHROME_BROWSER_SESSIONS_SESSION_COMMON_UTILS_H_	24 #endif // CHROME_BROWSER_SESSIONS_SESSION_COMMON_UTILS_H_

OLD	NEW