src/ast/ast.cc - Issue 2493553002: Fix -Wsign-compare warnings in parser, scanner, regexp, runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/ast.cc

Issue 2493553002: Fix -Wsign-compare warnings in parser, scanner, regexp, runtime. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/ast.cc

diff --git a/src/ast/ast.cc b/src/ast/ast.cc

index 530bd50aaf7e12fadf6860b241663b594c5c514c..7fa115524d1a852f8eb70b71fc631d4711971270 100644

--- a/src/ast/ast.cc

+++ b/src/ast/ast.cc

@@ -511,7 +511,7 @@ void ObjectLiteral::BuildConstantProperties(Isolate* isolate) {

continue;

}

- if (position == boilerplate_properties_ * 2) {

+ if (static_cast<uint32_t>(position) == boilerplate_properties_ * 2) {

DCHECK(property->is_computed_name());

is_simple = false;

break;

« no previous file with comments | « no previous file | src/base/cpu.cc » ('j') | no next file with comments »