Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: test/unittests/source-position-table-unittest.cc

Issue 2493553002: Fix -Wsign-compare warnings in parser, scanner, regexp, runtime. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-code-stub-assembler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/objects.h" 7 #include "src/objects.h"
8 #include "src/source-position-table.h" 8 #include "src/source-position-table.h"
9 #include "test/unittests/test-utils.h" 9 #include "test/unittests/test-utils.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace internal { 12 namespace internal {
13 namespace interpreter { 13 namespace interpreter {
14 14
15 class SourcePositionTableTest : public TestWithIsolateAndZone { 15 class SourcePositionTableTest : public TestWithIsolateAndZone {
16 public: 16 public:
17 SourcePositionTableTest() {} 17 SourcePositionTableTest() {}
18 ~SourcePositionTableTest() override {} 18 ~SourcePositionTableTest() override {}
19 }; 19 };
20 20
21 // Some random offsets, mostly at 'suspicious' bit boundaries. 21 // Some random offsets, mostly at 'suspicious' bit boundaries.
22 static int offsets[] = {0, 1, 2, 3, 4, 30, 31, 32, 22 static int offsets[] = {0, 1, 2, 3, 4, 30, 31, 32,
23 33, 62, 63, 64, 65, 126, 127, 128, 23 33, 62, 63, 64, 65, 126, 127, 128,
24 129, 250, 1000, 9999, 12000, 31415926}; 24 129, 250, 1000, 9999, 12000, 31415926};
25 25
26 TEST_F(SourcePositionTableTest, EncodeStatement) { 26 TEST_F(SourcePositionTableTest, EncodeStatement) {
27 SourcePositionTableBuilder builder(zone()); 27 SourcePositionTableBuilder builder(zone());
28 for (int i = 0; i < arraysize(offsets); i++) { 28 for (size_t i = 0; i < arraysize(offsets); i++) {
29 builder.AddPosition(offsets[i], offsets[i], true); 29 builder.AddPosition(offsets[i], offsets[i], true);
30 } 30 }
31 31
32 // To test correctness, we rely on the assertions in ToSourcePositionTable(). 32 // To test correctness, we rely on the assertions in ToSourcePositionTable().
33 // (Also below.) 33 // (Also below.)
34 CHECK(!builder.ToSourcePositionTable(isolate(), Handle<AbstractCode>()) 34 CHECK(!builder.ToSourcePositionTable(isolate(), Handle<AbstractCode>())
35 .is_null()); 35 .is_null());
36 } 36 }
37 37
38 TEST_F(SourcePositionTableTest, EncodeStatementDuplicates) { 38 TEST_F(SourcePositionTableTest, EncodeStatementDuplicates) {
39 SourcePositionTableBuilder builder(zone()); 39 SourcePositionTableBuilder builder(zone());
40 for (int i = 0; i < arraysize(offsets); i++) { 40 for (size_t i = 0; i < arraysize(offsets); i++) {
41 builder.AddPosition(offsets[i], offsets[i], true); 41 builder.AddPosition(offsets[i], offsets[i], true);
42 builder.AddPosition(offsets[i], offsets[i] + 1, true); 42 builder.AddPosition(offsets[i], offsets[i] + 1, true);
43 } 43 }
44 44
45 // To test correctness, we rely on the assertions in ToSourcePositionTable(). 45 // To test correctness, we rely on the assertions in ToSourcePositionTable().
46 // (Also below.) 46 // (Also below.)
47 CHECK(!builder.ToSourcePositionTable(isolate(), Handle<AbstractCode>()) 47 CHECK(!builder.ToSourcePositionTable(isolate(), Handle<AbstractCode>())
48 .is_null()); 48 .is_null());
49 } 49 }
50 50
51 TEST_F(SourcePositionTableTest, EncodeExpression) { 51 TEST_F(SourcePositionTableTest, EncodeExpression) {
52 SourcePositionTableBuilder builder(zone()); 52 SourcePositionTableBuilder builder(zone());
53 for (int i = 0; i < arraysize(offsets); i++) { 53 for (size_t i = 0; i < arraysize(offsets); i++) {
54 builder.AddPosition(offsets[i], offsets[i], false); 54 builder.AddPosition(offsets[i], offsets[i], false);
55 } 55 }
56 CHECK(!builder.ToSourcePositionTable(isolate(), Handle<AbstractCode>()) 56 CHECK(!builder.ToSourcePositionTable(isolate(), Handle<AbstractCode>())
57 .is_null()); 57 .is_null());
58 } 58 }
59 59
60 TEST_F(SourcePositionTableTest, EncodeAscending) { 60 TEST_F(SourcePositionTableTest, EncodeAscending) {
61 SourcePositionTableBuilder builder(zone()); 61 SourcePositionTableBuilder builder(zone());
62 62
63 int code_offset = 0; 63 int code_offset = 0;
64 int source_position = 0; 64 int source_position = 0;
65 for (int i = 0; i < arraysize(offsets); i++) { 65 for (size_t i = 0; i < arraysize(offsets); i++) {
66 code_offset += offsets[i]; 66 code_offset += offsets[i];
67 source_position += offsets[i]; 67 source_position += offsets[i];
68 if (i % 2) { 68 if (i % 2) {
69 builder.AddPosition(code_offset, source_position, true); 69 builder.AddPosition(code_offset, source_position, true);
70 } else { 70 } else {
71 builder.AddPosition(code_offset, source_position, false); 71 builder.AddPosition(code_offset, source_position, false);
72 } 72 }
73 } 73 }
74 74
75 // Also test negative offsets for source positions: 75 // Also test negative offsets for source positions:
76 for (int i = 0; i < arraysize(offsets); i++) { 76 for (size_t i = 0; i < arraysize(offsets); i++) {
77 code_offset += offsets[i]; 77 code_offset += offsets[i];
78 source_position -= offsets[i]; 78 source_position -= offsets[i];
79 if (i % 2) { 79 if (i % 2) {
80 builder.AddPosition(code_offset, source_position, true); 80 builder.AddPosition(code_offset, source_position, true);
81 } else { 81 } else {
82 builder.AddPosition(code_offset, source_position, false); 82 builder.AddPosition(code_offset, source_position, false);
83 } 83 }
84 } 84 }
85 85
86 CHECK(!builder.ToSourcePositionTable(isolate(), Handle<AbstractCode>()) 86 CHECK(!builder.ToSourcePositionTable(isolate(), Handle<AbstractCode>())
87 .is_null()); 87 .is_null());
88 } 88 }
89 89
90 } // namespace interpreter 90 } // namespace interpreter
91 } // namespace internal 91 } // namespace internal
92 } // namespace v8 92 } // namespace v8
OLDNEW
« no previous file with comments | « test/cctest/test-code-stub-assembler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698