[Downloads] Pass more DownloadItem state to java

[Download] Pass more DownloadItem state to java

* Pass information about incomplete downloads over to Java.

* Consolidate how DownloadItems are created in DownloadManagerService
  so that it's consistent.

BUG=658246
Committed: https://crrev.com/23ce0eee3440969f225e787f8eccf622dfc922ba
Cr-Commit-Position: refs/heads/master@{#431318}

[gone, 2016-11-09 23:30:02]

dfalcantara@chromium.org changed reviewers:
+ qinmin@chromium.org

[qinmin, 2016-11-10 18:29:10]

https://codereview.chromium.org/2493543003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
(right):

https://codereview.chromium.org/2493543003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:22:
private boolean mIsPaused;
isPaused is already available in mDownloadInfo, you can reuse that. Similarly,
state can could be moved to DownloadInfo.

Sooner or later the downloadItem and DownloadInfo should merge with each other,
as we no longer uses Android DownloadManager (only for a special case).

[gone, 2016-11-10 18:44:30]

https://codereview.chromium.org/2493543003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
(right):

https://codereview.chromium.org/2493543003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:22:
private boolean mIsPaused;
On 2016/11/10 18:29:10, qinmin wrote:
> isPaused is already available in mDownloadInfo, you can reuse that. Similarly,
> state can could be moved to DownloadInfo.
> 
> Sooner or later the downloadItem and DownloadInfo should merge with each
other,
> as we no longer uses Android DownloadManager (only for a special case).

Done.

[gone, 2016-11-10 18:50:29]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 18:51:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qinmin, 2016-11-10 18:56:28]

lgtm

[gone, 2016-11-10 18:56:57]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2016-11-10 18:57:00]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-11-10 18:57:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 19:38:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-10 20:10:36]

Description was changed from

==========
[Download] Pass more DownloadItem state to java

* Pass information about incomplete downloads over to Java.

* Consolidate how DownloadItems are created in DownloadManagerService
  so that it's consistent.

BUG=658246
==========

to

==========
[Download] Pass more DownloadItem state to java

* Pass information about incomplete downloads over to Java.

* Consolidate how DownloadItems are created in DownloadManagerService
  so that it's consistent.

BUG=658246

Committed: https://crrev.com/23ce0eee3440969f225e787f8eccf622dfc922ba
Cr-Commit-Position: refs/heads/master@{#431318}
==========

[commit-bot: I haz the power, 2016-11-10 20:10:36]

Patchset 4 (id:??) landed as
https://crrev.com/23ce0eee3440969f225e787f8eccf622dfc922ba
Cr-Commit-Position: refs/heads/master@{#431318}