Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: src/debug/debug.cc

Issue 2493533003: [debug] Extend a test and fix some typos. (Closed)
Patch Set: Address feedback and reset listener at the end. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/debug-set-variable-value.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index cb1f34f390e50b54eab226359e504ec39ca10c7b..4a92dfabdb62f89403f4daea7b8ef5d95d8a1502 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -1945,7 +1945,7 @@ void Debug::CallEventCallback(v8::DebugEvent event,
MaybeHandle<Object> result =
Execution::Call(isolate_, Handle<JSFunction>::cast(event_listener_),
global, arraysize(argv), argv);
- CHECK(!result.is_null()); // Listeners may not throw.
+ CHECK(!result.is_null()); // Listeners must not throw.
}
in_debug_event_listener_ = previous;
}
« no previous file with comments | « no previous file | test/mjsunit/debug-set-variable-value.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698