[debug] Extend a test and fix some typos.

[debug] Extend a test and fix some typos.

R=jgruber@chromium.org
BUG=

Committed: https://crrev.com/4e32419be4c68e8e35e7ebf477c9cc1d840279cd
Cr-Commit-Position: refs/heads/master@{#40966}

[jgruber, 2016-11-10 16:30:05]

lgtm, thanks!

https://codereview.chromium.org/2493533003/diff/1/test/mjsunit/debug-set-vari...
File test/mjsunit/debug-set-variable-value.js (right):

https://codereview.chromium.org/2493533003/diff/1/test/mjsunit/debug-set-vari...
test/mjsunit/debug-set-variable-value.js:316: if (event ==
Debug.DebugEvent.Break) {
FYI: Exceptions thrown in debug listeners cause a crash at a location where it
might not immediately be clear to the developer what the actual cause was (see
debug.cc:1948).

It may be better style to catch (and print) exceptions within the listener, and
check that the listener completed successfully.

But I'm also fine with landing this as-is, your call.

[neis, 2016-11-11 11:28:01]

On 2016/11/10 16:30:05, jgruber wrote:
> lgtm, thanks!
> 
>
https://codereview.chromium.org/2493533003/diff/1/test/mjsunit/debug-set-vari...
> File test/mjsunit/debug-set-variable-value.js (right):
> 
>
https://codereview.chromium.org/2493533003/diff/1/test/mjsunit/debug-set-vari...
> test/mjsunit/debug-set-variable-value.js:316: if (event ==
> Debug.DebugEvent.Break) {
> FYI: Exceptions thrown in debug listeners cause a crash at a location where it
> might not immediately be clear to the developer what the actual cause was (see
> debug.cc:1948).

Yes, I had noticed that :)

> It may be better style to catch (and print) exceptions within the listener,
and
> check that the listener completed successfully.

Done.

[neis, 2016-11-11 15:00:18]

This is blocked by https://bugs.chromium.org/p/v8/issues/detail?id=5627 for now.

[neis, 2016-11-14 12:59:48]

The CQ bit was checked by neis@chromium.org

[neis, 2016-11-14 12:59:49]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2493533003/#ps20001
(title: "Address feedback and reset listener at the end.")

[commit-bot: I haz the power, 2016-11-14 12:59:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 14:05:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:32:40]

Description was changed from

==========
[debug] Extend a test and fix some typos.

R=jgruber@chromium.org
BUG=
==========

to

==========
[debug] Extend a test and fix some typos.

R=jgruber@chromium.org
BUG=

Committed: https://crrev.com/4e32419be4c68e8e35e7ebf477c9cc1d840279cd
Cr-Commit-Position: refs/heads/master@{#40966}
==========

[commit-bot: I haz the power, 2016-11-17 22:32:41]

Patchset 2 (id:??) landed as
https://crrev.com/4e32419be4c68e8e35e7ebf477c9cc1d840279cd
Cr-Commit-Position: refs/heads/master@{#40966}