Apply the correct style to first-letter pseudo elements composed of different renderers

Apply the correct style to first-letter pseudo elements composed of different renderers

Traverse (in preorder) the whole subtree under a render block with a first-letter selector when
looking for the text renderers which would need to get the apropriate style applied, instead of
only considering the first renderer only, which might not contain all the text that should be
considered as a "first letter" (leading and trailing punctuation should be included too).

The present patch also considers leading spaces, if any, as part of the first-letter element,
to match the behaviour of other renderers such as IE and Opera (Firefox does not do that).

R=eseidel@chromium.org, eae@chromium.org, leviw@chromium.org
BUG=354403
TEST=Add new test to check first-letter elements composed of different renderers.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172391

[mario.prada, 2014-04-23 14:17:47]

https://codereview.chromium.org/249353003/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlock.cpp (right):

https://codereview.chromium.org/249353003/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlock.cpp:4066: m_renderers.clear();
This line is the main change compared to the patch set committed in r170677[1],
to avoid crashes observed under certain scenarios.

Please review

[1] https://src.chromium.org/viewvc/blink?view=rev&revision=170677

[eseidel, 2014-04-23 15:33:41]

lgtm

OK

[commit-bot: I haz the power, 2014-04-23 15:35:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mario.prada@samsung.com/249353003/1

[commit-bot: I haz the power, 2014-04-23 16:52:01]

Change committed as 172391