Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2493503002: Revert of Add virtual tests for XHR with mojo-loading (Closed)

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
nasko, yhirano, tzik
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, blink-reviews, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add virtual tests for XHR with mojo-loading (patchset #9 id:160001 of https://codereview.chromium.org/2463753002/ ) Reason for revert: The new tests fail when OOPIFs (out of process iframes / aka remote frames) are possible and turn the Site Isolation Win bot red. Most likely failure modes differ between --site-per-process mode and the expectations landed in this CL in third_party/WebKit/LayoutTests/TestExpectations (so maybe the experimental feature needs to also maintain a separate set of test expectations in third_party/WebKit/LayoutTests/FlagExpectations/site-per-process). Example red build: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/16899 Original issue's description: > Add virtual tests for XHR with mojo-loading > > This CL adds virtual XHR tests with mojo-loading as > virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of > failures. We add them to TestExpectations and will fix them later. > > BUG=659917, 662360 > > Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a > Committed: https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae > Cr-Original-Commit-Position: refs/heads/master@{#429808} > Cr-Commit-Position: refs/heads/master@{#430874} TBR=tzik@chromium.org,nasko@chromium.org,yhirano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659917, 662360 Committed: https://crrev.com/83cd4c25b6cc96731b0f028a5b71baf2d3a74dd5 Cr-Commit-Position: refs/heads/master@{#430970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -67 lines) Patch
M content/child/url_response_body_consumer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -62 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/xmlhttprequest/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/xmlhttprequest/web-apps/README.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Łukasz Anforowicz
Created Revert of Add virtual tests for XHR with mojo-loading
4 years, 1 month ago (2016-11-09 17:54:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493503002/1
4 years, 1 month ago (2016-11-09 17:54:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 17:55:28 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 18:02:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83cd4c25b6cc96731b0f028a5b71baf2d3a74dd5
Cr-Commit-Position: refs/heads/master@{#430970}

Powered by Google App Engine
This is Rietveld 408576698