Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2493473002: Reduce amount of boilerplate associated with bootstrap libraries. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reduce amount of boilerplate associated with bootstrap libraries. R=fschneider@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6dce6e87f871d729f5cc8bda0ef2685e43e1d677

Patch Set 1 #

Patch Set 2 : Address Florian's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -207 lines) Patch
M runtime/vm/bootstrap.h View 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 8 chunks +101 lines, -133 lines 0 comments Download
M runtime/vm/bootstrap_nocore.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/object_store.h View 5 chunks +59 lines, -64 lines 0 comments Download
M runtime/vm/object_store.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
PTAL
4 years, 1 month ago (2016-11-09 14:35:45 UTC) #1
Florian Schneider
Thanks! LGTM
4 years, 1 month ago (2016-11-09 14:54:10 UTC) #2
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-11-09 15:38:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6dce6e87f871d729f5cc8bda0ef2685e43e1d677 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698