[wasm] Only immutable imported globals are valid initializer expressions

[wasm] Only immutable imported globals are valid initializer expressions

R=titzer@chromium.org
TEST=unittests/WasmModuleVerifyTest.DataSegmentWithImmutableGlobal, unittests/WasmModuleVerifyTest.DataSegmentWithMutableImportedGlobal, unittests/WasmModuleVerifyTest.DataSegmentWithImmutableImportedGlobal

Committed: https://crrev.com/d91bed67d6115acc38a73d875e13e33613801c1e
Cr-Commit-Position: refs/heads/master@{#40865}

[ahaas, 2016-11-09 13:19:41]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 13:19:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-11-09 13:26:44]

https://codereview.chromium.org/2493433002/diff/1/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/2493433002/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:914: printf("error\n");
stray printfs remaining here

https://codereview.chromium.org/2493433002/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:921: if (!global || global->mutability ||
!global->imported) {
I don't think that !global can ever be true.

[commit-bot: I haz the power, 2016-11-09 13:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 13:34:04]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[ahaas, 2016-11-09 14:19:10]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 14:19:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-11-09 14:21:17]

I also removed obsolete tests which expect invalid wasm modules (according to
the design document) to validate.

https://codereview.chromium.org/2493433002/diff/1/src/wasm/module-decoder.cc
File src/wasm/module-decoder.cc (right):

https://codereview.chromium.org/2493433002/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:914: printf("error\n");
On 2016/11/09 at 13:26:43, titzer wrote:
> stray printfs remaining here

Removed.

https://codereview.chromium.org/2493433002/diff/1/src/wasm/module-decoder.cc#...
src/wasm/module-decoder.cc:921: if (!global || global->mutability ||
!global->imported) {
On 2016/11/09 at 13:26:43, titzer wrote:
> I don't think that !global can ever be true.

Removed.

[commit-bot: I haz the power, 2016-11-09 14:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 14:32:33]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[ahaas, 2016-11-09 15:10:13]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 15:10:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 15:36:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 15:36:14]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-11-09 15:47:34]

On 2016/11/09 14:21:17, ahaas wrote:
> I also removed obsolete tests which expect invalid wasm modules (according to
> the design document) to validate.
> 
> https://codereview.chromium.org/2493433002/diff/1/src/wasm/module-decoder.cc
> File src/wasm/module-decoder.cc (right):
> 
>
https://codereview.chromium.org/2493433002/diff/1/src/wasm/module-decoder.cc#...
> src/wasm/module-decoder.cc:914: printf("error\n");
> On 2016/11/09 at 13:26:43, titzer wrote:
> > stray printfs remaining here
> 
> Removed.
> 
>
https://codereview.chromium.org/2493433002/diff/1/src/wasm/module-decoder.cc#...
> src/wasm/module-decoder.cc:921: if (!global || global->mutability ||
> !global->imported) {
> On 2016/11/09 at 13:26:43, titzer wrote:
> > I don't think that !global can ever be true.
> 
> Removed.

lgtm

[ahaas, 2016-11-09 15:50:00]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-11-09 15:50:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 15:52:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:27:45]

Description was changed from

==========
[wasm] Only immutable imported globals are valid initializer expressions

R=titzer@chromium.org
TEST=unittests/WasmModuleVerifyTest.DataSegmentWithImmutableGlobal,
unittests/WasmModuleVerifyTest.DataSegmentWithMutableImportedGlobal,
unittests/WasmModuleVerifyTest.DataSegmentWithImmutableImportedGlobal
==========

to

==========
[wasm] Only immutable imported globals are valid initializer expressions

R=titzer@chromium.org
TEST=unittests/WasmModuleVerifyTest.DataSegmentWithImmutableGlobal,
unittests/WasmModuleVerifyTest.DataSegmentWithMutableImportedGlobal,
unittests/WasmModuleVerifyTest.DataSegmentWithImmutableImportedGlobal

Committed: https://crrev.com/d91bed67d6115acc38a73d875e13e33613801c1e
Cr-Commit-Position: refs/heads/master@{#40865}
==========

[commit-bot: I haz the power, 2016-11-17 22:27:46]

Patchset 3 (id:??) landed as
https://crrev.com/d91bed67d6115acc38a73d875e13e33613801c1e
Cr-Commit-Position: refs/heads/master@{#40865}