Source/platform/fonts/mac/FontMac.cpp - Issue 249343002: Create an antialiased virtual layout test group for font testing on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/mac/FontMac.cpp

Issue 249343002: Create an antialiased virtual layout test group for font testing on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addressed, uploading with --no-find-copies Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/virtual/mac-antialiasedtext/fast/text/word-space-with-kerning-2-expected.html ('k') | Tools/Scripts/webkitpy/layout_tests/port/base.py » ('j') | Tools/Scripts/webkitpy/layout_tests/port/base.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/mac/FontMac.cpp

diff --git a/Source/platform/fonts/mac/FontMac.cpp b/Source/platform/fonts/mac/FontMac.cpp

index 94340a12ff50c6e71a0acc55776b222a6261abde..05f2c625e7f40940756326aba717d5bfb472a5f0 100644

--- a/Source/platform/fonts/mac/FontMac.cpp

+++ b/Source/platform/fonts/mac/FontMac.cpp

@@ -105,7 +105,8 @@ void Font::drawGlyphs(GraphicsContext* gc, const SimpleFontData* font,

if (isRunningLayoutTest()) {

shouldSmoothFonts = false;

- shouldAntialias = false;

+ // FIXME: isFontSmoothingEnabledForTest() really means isFontAntialiasingEnabledForTest()

Dirk Pranke 2014/04/25 15:43:39 Nit: please include the bug number in the comment.

+ shouldAntialias = shouldAntialias && isFontSmoothingEnabledForTest();

}

const GlyphBufferGlyph* glyphs = glyphBuffer.glyphs(from);