Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/SortableDataGrid.js

Issue 2493373002: DevTools: rename WebInspector into modules. (Closed)
Patch Set: for bots Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/SortableDataGrid.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/SortableDataGrid.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/SortableDataGrid.js
index 5df5cbb2736a4e09702358dcd2245b16b2aba571..c29de9012b5f2658f8af2ecca159c5134a02b31f 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/SortableDataGrid.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/SortableDataGrid.js
@@ -4,23 +4,23 @@
/**
* @unrestricted
*/
-WebInspector.SortableDataGrid = class extends WebInspector.ViewportDataGrid {
+UI.SortableDataGrid = class extends UI.ViewportDataGrid {
/**
- * @param {!Array<!WebInspector.DataGrid.ColumnDescriptor>} columnsArray
- * @param {function(!WebInspector.DataGridNode, string, string, string)=} editCallback
- * @param {function(!WebInspector.DataGridNode)=} deleteCallback
+ * @param {!Array<!UI.DataGrid.ColumnDescriptor>} columnsArray
+ * @param {function(!UI.DataGridNode, string, string, string)=} editCallback
+ * @param {function(!UI.DataGridNode)=} deleteCallback
* @param {function()=} refreshCallback
*/
constructor(columnsArray, editCallback, deleteCallback, refreshCallback) {
super(columnsArray, editCallback, deleteCallback, refreshCallback);
- /** @type {!WebInspector.SortableDataGrid.NodeComparator} */
- this._sortingFunction = WebInspector.SortableDataGrid.TrivialComparator;
- this.setRootNode(new WebInspector.SortableDataGridNode());
+ /** @type {!UI.SortableDataGrid.NodeComparator} */
+ this._sortingFunction = UI.SortableDataGrid.TrivialComparator;
+ this.setRootNode(new UI.SortableDataGridNode());
}
/**
- * @param {!WebInspector.DataGridNode} a
- * @param {!WebInspector.DataGridNode} b
+ * @param {!UI.DataGridNode} a
+ * @param {!UI.DataGridNode} b
* @return {number}
*/
static TrivialComparator(a, b) {
@@ -29,8 +29,8 @@ WebInspector.SortableDataGrid = class extends WebInspector.ViewportDataGrid {
/**
* @param {string} columnId
- * @param {!WebInspector.DataGridNode} a
- * @param {!WebInspector.DataGridNode} b
+ * @param {!UI.DataGridNode} a
+ * @param {!UI.DataGridNode} b
* @return {number}
*/
static NumericComparator(columnId, a, b) {
@@ -43,8 +43,8 @@ WebInspector.SortableDataGrid = class extends WebInspector.ViewportDataGrid {
/**
* @param {string} columnId
- * @param {!WebInspector.DataGridNode} a
- * @param {!WebInspector.DataGridNode} b
+ * @param {!UI.DataGridNode} a
+ * @param {!UI.DataGridNode} b
* @return {number}
*/
static StringComparator(columnId, a, b) {
@@ -56,10 +56,10 @@ WebInspector.SortableDataGrid = class extends WebInspector.ViewportDataGrid {
}
/**
- * @param {!WebInspector.SortableDataGrid.NodeComparator} comparator
+ * @param {!UI.SortableDataGrid.NodeComparator} comparator
* @param {boolean} reverseMode
- * @param {!WebInspector.DataGridNode} a
- * @param {!WebInspector.DataGridNode} b
+ * @param {!UI.DataGridNode} a
+ * @param {!UI.DataGridNode} b
* @return {number}
*/
static Comparator(comparator, reverseMode, a, b) {
@@ -69,14 +69,14 @@ WebInspector.SortableDataGrid = class extends WebInspector.ViewportDataGrid {
/**
* @param {!Array.<string>} columnNames
* @param {!Array.<string>} values
- * @return {?WebInspector.SortableDataGrid}
+ * @return {?UI.SortableDataGrid}
*/
static create(columnNames, values) {
var numColumns = columnNames.length;
if (!numColumns)
return null;
- var columns = /** @type {!Array<!WebInspector.DataGrid.ColumnDescriptor>} */ ([]);
+ var columns = /** @type {!Array<!UI.DataGrid.ColumnDescriptor>} */ ([]);
for (var i = 0; i < columnNames.length; ++i)
columns.push({id: String(i), title: columnNames[i], width: columnNames[i].length, sortable: true});
@@ -86,18 +86,18 @@ WebInspector.SortableDataGrid = class extends WebInspector.ViewportDataGrid {
for (var j = 0; j < columnNames.length; ++j)
data[j] = values[numColumns * i + j];
- var node = new WebInspector.SortableDataGridNode(data);
+ var node = new UI.SortableDataGridNode(data);
node.selectable = false;
nodes.push(node);
}
- var dataGrid = new WebInspector.SortableDataGrid(columns);
+ var dataGrid = new UI.SortableDataGrid(columns);
var length = nodes.length;
var rootNode = dataGrid.rootNode();
for (var i = 0; i < length; ++i)
rootNode.appendChild(nodes[i]);
- dataGrid.addEventListener(WebInspector.DataGrid.Events.SortingChanged, sortDataGrid);
+ dataGrid.addEventListener(UI.DataGrid.Events.SortingChanged, sortDataGrid);
function sortDataGrid() {
var nodes = dataGrid.rootNode().children;
@@ -114,40 +114,40 @@ WebInspector.SortableDataGrid = class extends WebInspector.ViewportDataGrid {
}
}
- var comparator = columnIsNumeric ? WebInspector.SortableDataGrid.NumericComparator :
- WebInspector.SortableDataGrid.StringComparator;
+ var comparator = columnIsNumeric ? UI.SortableDataGrid.NumericComparator :
+ UI.SortableDataGrid.StringComparator;
dataGrid.sortNodes(comparator.bind(null, sortColumnId), !dataGrid.isSortOrderAscending());
}
return dataGrid;
}
/**
- * @param {!WebInspector.DataGridNode} node
+ * @param {!UI.DataGridNode} node
*/
insertChild(node) {
- var root = /** @type {!WebInspector.SortableDataGridNode} */ (this.rootNode());
+ var root = /** @type {!UI.SortableDataGridNode} */ (this.rootNode());
root.insertChildOrdered(node);
}
/**
- * @param {!WebInspector.SortableDataGrid.NodeComparator} comparator
+ * @param {!UI.SortableDataGrid.NodeComparator} comparator
* @param {boolean} reverseMode
*/
sortNodes(comparator, reverseMode) {
- this._sortingFunction = WebInspector.SortableDataGrid.Comparator.bind(null, comparator, reverseMode);
+ this._sortingFunction = UI.SortableDataGrid.Comparator.bind(null, comparator, reverseMode);
this._rootNode._sortChildren(reverseMode);
this.scheduleUpdateStructure();
}
};
-/** @typedef {function(!WebInspector.DataGridNode, !WebInspector.DataGridNode):number} */
-WebInspector.SortableDataGrid.NodeComparator;
+/** @typedef {function(!UI.DataGridNode, !UI.DataGridNode):number} */
+UI.SortableDataGrid.NodeComparator;
/**
* @unrestricted
*/
-WebInspector.SortableDataGridNode = class extends WebInspector.ViewportDataGridNode {
+UI.SortableDataGridNode = class extends UI.ViewportDataGridNode {
/**
* @param {?Object.<string, *>=} data
* @param {boolean=} hasChildren
@@ -157,7 +157,7 @@ WebInspector.SortableDataGridNode = class extends WebInspector.ViewportDataGridN
}
/**
- * @param {!WebInspector.DataGridNode} node
+ * @param {!UI.DataGridNode} node
*/
insertChildOrdered(node) {
this.insertChild(node, this.children.upperBound(node, this.dataGrid._sortingFunction));

Powered by Google App Engine
This is Rietveld 408576698