Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/Script.js

Issue 2493373002: DevTools: rename WebInspector into modules. (Closed)
Patch Set: for bots Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/Script.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/Script.js b/third_party/WebKit/Source/devtools/front_end/sdk/Script.js
index 7691c8c21b40336a0c05450a4e69614b72a6b0a6..11571dddb2a5ccf6b051c275d89726aead6036c5 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/Script.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/Script.js
@@ -23,12 +23,12 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
/**
- * @implements {WebInspector.ContentProvider}
+ * @implements {Common.ContentProvider}
* @unrestricted
*/
-WebInspector.Script = class extends WebInspector.SDKObject {
+SDK.Script = class extends SDK.SDKObject {
/**
- * @param {!WebInspector.DebuggerModel} debuggerModel
+ * @param {!SDK.DebuggerModel} debuggerModel
* @param {string} scriptId
* @param {string} sourceURL
* @param {number} startLine
@@ -87,13 +87,13 @@ WebInspector.Script = class extends WebInspector.SDKObject {
if (sourceURLLineIndex === -1)
return source;
var sourceURLLine = source.substr(sourceURLLineIndex + 1).split('\n', 1)[0];
- if (sourceURLLine.search(WebInspector.Script.sourceURLRegex) === -1)
+ if (sourceURLLine.search(SDK.Script.sourceURLRegex) === -1)
return source;
return source.substr(0, sourceURLLineIndex) + source.substr(sourceURLLineIndex + sourceURLLine.length + 1);
}
/**
- * @param {!WebInspector.Script} script
+ * @param {!SDK.Script} script
* @param {string} source
*/
static _reportDeprecatedCommentIfNeeded(script, source) {
@@ -112,10 +112,10 @@ WebInspector.Script = class extends WebInspector.SDKObject {
return;
if (sourceTail.search(/^[\040\t]*\/\/@ source(mapping)?url=/mi) === -1)
return;
- var text = WebInspector.UIString(
+ var text = Common.UIString(
'\'//@ sourceURL\' and \'//@ sourceMappingURL\' are deprecated, please use \'//# sourceURL=\' and \'//# sourceMappingURL=\' instead.');
- var msg = new WebInspector.ConsoleMessage(
- script.target(), WebInspector.ConsoleMessage.MessageSource.JS, WebInspector.ConsoleMessage.MessageLevel.Warning,
+ var msg = new SDK.ConsoleMessage(
+ script.target(), SDK.ConsoleMessage.MessageSource.JS, SDK.ConsoleMessage.MessageLevel.Warning,
text, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined,
script.scriptId);
consoleModel.addMessage(msg);
@@ -129,7 +129,7 @@ WebInspector.Script = class extends WebInspector.SDKObject {
}
/**
- * @return {?WebInspector.ExecutionContext}
+ * @return {?SDK.ExecutionContext}
*/
executionContext() {
return this.target().runtimeModel.executionContext(this._executionContextId);
@@ -152,10 +152,10 @@ WebInspector.Script = class extends WebInspector.SDKObject {
/**
* @override
- * @return {!WebInspector.ResourceType}
+ * @return {!Common.ResourceType}
*/
contentType() {
- return WebInspector.resourceTypes.Script;
+ return Common.resourceTypes.Script;
}
/**
@@ -174,14 +174,14 @@ WebInspector.Script = class extends WebInspector.SDKObject {
return promise;
/**
- * @this {WebInspector.Script}
+ * @this {SDK.Script}
* @param {?Protocol.Error} error
* @param {string} source
*/
function didGetScriptSource(error, source) {
if (!error) {
- WebInspector.Script._reportDeprecatedCommentIfNeeded(this, source);
- this._source = WebInspector.Script._trimSourceURLComment(source);
+ SDK.Script._reportDeprecatedCommentIfNeeded(this, source);
+ this._source = SDK.Script._trimSourceURLComment(source);
} else {
this._source = '';
}
@@ -210,7 +210,7 @@ WebInspector.Script = class extends WebInspector.SDKObject {
var result = [];
for (var i = 0; i < searchMatches.length; ++i) {
var searchMatch =
- new WebInspector.ContentProvider.SearchMatch(searchMatches[i].lineNumber, searchMatches[i].lineContent);
+ new Common.ContentProvider.SearchMatch(searchMatches[i].lineNumber, searchMatches[i].lineContent);
result.push(searchMatch);
}
callback(result || []);
@@ -240,7 +240,7 @@ WebInspector.Script = class extends WebInspector.SDKObject {
*/
editSource(newSource, callback) {
/**
- * @this {WebInspector.Script}
+ * @this {SDK.Script}
* @param {?Protocol.Error} error
* @param {!Array.<!Protocol.Debugger.CallFrame>=} callFrames
* @param {boolean=} stackChanged
@@ -254,7 +254,7 @@ WebInspector.Script = class extends WebInspector.SDKObject {
callback(error, exceptionDetails, callFrames, asyncStackTrace, needsStepIn);
}
- newSource = WebInspector.Script._trimSourceURLComment(newSource);
+ newSource = SDK.Script._trimSourceURLComment(newSource);
// We append correct sourceURL to script for consistency only. It's not actually needed for things to work correctly.
newSource = this._appendSourceURLCommentIfNeeded(newSource);
@@ -268,10 +268,10 @@ WebInspector.Script = class extends WebInspector.SDKObject {
/**
* @param {number} lineNumber
* @param {number=} columnNumber
- * @return {!WebInspector.DebuggerModel.Location}
+ * @return {!SDK.DebuggerModel.Location}
*/
rawLocation(lineNumber, columnNumber) {
- return new WebInspector.DebuggerModel.Location(this.debuggerModel, this.scriptId, lineNumber, columnNumber || 0);
+ return new SDK.DebuggerModel.Location(this.debuggerModel, this.scriptId, lineNumber, columnNumber || 0);
}
/**
@@ -289,7 +289,7 @@ WebInspector.Script = class extends WebInspector.SDKObject {
if (this.sourceMapURL)
return;
this.sourceMapURL = sourceMapURL;
- this.dispatchEventToListeners(WebInspector.Script.Events.SourceMapURLAdded, this.sourceMapURL);
+ this.dispatchEventToListeners(SDK.Script.Events.SourceMapURLAdded, this.sourceMapURL);
}
/**
@@ -316,7 +316,7 @@ WebInspector.Script = class extends WebInspector.SDKObject {
/**
* @param {function(?)} fulfill
* @param {function(*)} reject
- * @this {WebInspector.Script}
+ * @this {SDK.Script}
*/
function setBlackboxedRanges(fulfill, reject) {
this.target().debuggerAgent().setBlackboxedRanges(this.scriptId, positions, callback);
@@ -333,9 +333,9 @@ WebInspector.Script = class extends WebInspector.SDKObject {
};
/** @enum {symbol} */
-WebInspector.Script.Events = {
+SDK.Script.Events = {
ScriptEdited: Symbol('ScriptEdited'),
SourceMapURLAdded: Symbol('SourceMapURLAdded')
};
-WebInspector.Script.sourceURLRegex = /^[\040\t]*\/\/[@#] sourceURL=\s*(\S*?)\s*$/m;
+SDK.Script.sourceURLRegex = /^[\040\t]*\/\/[@#] sourceURL=\s*(\S*?)\s*$/m;

Powered by Google App Engine
This is Rietveld 408576698