Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: runtime/vm/intermediate_language_dbc.cc

Issue 2493353002: DBC: Fix checked mode stack traces (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_DBC. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_DBC.
6 #if defined(TARGET_ARCH_DBC) 6 #if defined(TARGET_ARCH_DBC)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 } 195 }
196 196
197 if (compiler->is_optimizing()) { 197 if (compiler->is_optimizing()) {
198 __ Push(locs()->in(0).reg()); // Value. 198 __ Push(locs()->in(0).reg()); // Value.
199 __ Push(locs()->in(1).reg()); // Instantiator type arguments. 199 __ Push(locs()->in(1).reg()); // Instantiator type arguments.
200 } 200 }
201 201
202 __ PushConstant(type()); 202 __ PushConstant(type());
203 __ PushConstant(test_cache); 203 __ PushConstant(test_cache);
204 __ InstanceOf(negate_result() ? 1 : 0); 204 __ InstanceOf(negate_result() ? 1 : 0);
205 compiler->RecordSafepoint(locs());
206 compiler->AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id(), 205 compiler->AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id(),
Florian Schneider 2016/11/11 23:48:59 Still needed?
zra 2016/11/12 05:29:03 ditto
207 token_pos()); 206 token_pos());
208 207 compiler->RecordAfterCall(this);
209 if (compiler->is_optimizing()) { 208 if (compiler->is_optimizing()) {
210 __ PopLocal(locs()->out(0).reg()); 209 __ PopLocal(locs()->out(0).reg());
211 } 210 }
212 } 211 }
213 212
214 213
215 DEFINE_MAKE_LOCATION_SUMMARY(AssertAssignable, 214 DEFINE_MAKE_LOCATION_SUMMARY(AssertAssignable,
216 2, 215 2,
217 Location::SameAsFirstInput(), 216 Location::SameAsFirstInput(),
218 LocationSummary::kCall); 217 LocationSummary::kCall);
219 218
220 219
221 EMIT_NATIVE_CODE(AssertBoolean, 220 EMIT_NATIVE_CODE(AssertBoolean,
222 1, 221 1,
223 Location::SameAsFirstInput(), 222 Location::SameAsFirstInput(),
224 LocationSummary::kCall) { 223 LocationSummary::kCall) {
225 if (compiler->is_optimizing()) { 224 if (compiler->is_optimizing()) {
226 __ Push(locs()->in(0).reg()); 225 __ Push(locs()->in(0).reg());
227 } 226 }
228 __ AssertBoolean(Isolate::Current()->type_checks() ? 1 : 0); 227 __ AssertBoolean(Isolate::Current()->type_checks() ? 1 : 0);
229 compiler->RecordSafepoint(locs());
230 compiler->AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id(), 228 compiler->AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id(),
Florian Schneider 2016/11/11 23:48:59 Same here.
zra 2016/11/12 05:29:03 ditto
231 token_pos()); 229 token_pos());
230 compiler->RecordAfterCall(this);
232 if (compiler->is_optimizing()) { 231 if (compiler->is_optimizing()) {
233 __ Drop1(); 232 __ Drop1();
234 } 233 }
235 } 234 }
236 235
237 236
238 EMIT_NATIVE_CODE(PolymorphicInstanceCall, 237 EMIT_NATIVE_CODE(PolymorphicInstanceCall,
239 0, 238 0,
240 Location::RegisterLocation(0), 239 Location::RegisterLocation(0),
241 LocationSummary::kCall) { 240 LocationSummary::kCall) {
(...skipping 1747 matching lines...) Expand 10 before | Expand all | Expand 10 after
1989 } 1988 }
1990 __ IfULe(length, index); 1989 __ IfULe(length, index);
1991 compiler->EmitDeopt(deopt_id(), ICData::kDeoptCheckArrayBound, 1990 compiler->EmitDeopt(deopt_id(), ICData::kDeoptCheckArrayBound,
1992 (generalized_ ? ICData::kGeneralized : 0) | 1991 (generalized_ ? ICData::kGeneralized : 0) |
1993 (licm_hoisted_ ? ICData::kHoisted : 0)); 1992 (licm_hoisted_ ? ICData::kHoisted : 0));
1994 } 1993 }
1995 1994
1996 } // namespace dart 1995 } // namespace dart
1997 1996
1998 #endif // defined TARGET_ARCH_DBC 1997 #endif // defined TARGET_ARCH_DBC
OLDNEW
« runtime/vm/flow_graph_compiler_dbc.cc ('K') | « runtime/vm/flow_graph_compiler_dbc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698