Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2163)

Unified Diff: content/renderer/render_widget_fullscreen_pepper.cc

Issue 2493293002: RenderWidget: make routing_id be a parameter of the ctor (Closed)
Patch Set: Add a release for asan bots. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_widget_fullscreen_pepper.h ('k') | content/renderer/render_widget_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget_fullscreen_pepper.cc
diff --git a/content/renderer/render_widget_fullscreen_pepper.cc b/content/renderer/render_widget_fullscreen_pepper.cc
index 6436a25e4b73196ddd2646fa7c4284ef175b3a07..13a9286738bdce60818ff1807c20deec474b79ca 100644
--- a/content/renderer/render_widget_fullscreen_pepper.cc
+++ b/content/renderer/render_widget_fullscreen_pepper.cc
@@ -252,26 +252,29 @@ class PepperWidget : public WebWidget {
// static
RenderWidgetFullscreenPepper* RenderWidgetFullscreenPepper::Create(
+ int32_t routing_id,
int32_t opener_id,
CompositorDependencies* compositor_deps,
PepperPluginInstanceImpl* plugin,
const GURL& active_url,
const ScreenInfo& screen_info) {
+ DCHECK_NE(MSG_ROUTING_NONE, routing_id);
DCHECK_NE(MSG_ROUTING_NONE, opener_id);
scoped_refptr<RenderWidgetFullscreenPepper> widget(
- new RenderWidgetFullscreenPepper(compositor_deps, plugin, active_url,
- screen_info));
+ new RenderWidgetFullscreenPepper(routing_id, compositor_deps, plugin,
+ active_url, screen_info));
widget->Init(opener_id);
widget->AddRef();
return widget.get();
}
RenderWidgetFullscreenPepper::RenderWidgetFullscreenPepper(
+ int32_t routing_id,
CompositorDependencies* compositor_deps,
PepperPluginInstanceImpl* plugin,
const GURL& active_url,
const ScreenInfo& screen_info)
- : RenderWidgetFullscreen(compositor_deps, screen_info),
+ : RenderWidgetFullscreen(routing_id, compositor_deps, screen_info),
active_url_(active_url),
plugin_(plugin),
layer_(NULL),
« no previous file with comments | « content/renderer/render_widget_fullscreen_pepper.h ('k') | content/renderer/render_widget_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698