Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: content/renderer/render_widget_fullscreen.cc

Issue 2493293002: RenderWidget: make routing_id be a parameter of the ctor (Closed)
Patch Set: Add a release for asan bots. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_widget_fullscreen.h ('k') | content/renderer/render_widget_fullscreen_pepper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget_fullscreen.cc
diff --git a/content/renderer/render_widget_fullscreen.cc b/content/renderer/render_widget_fullscreen.cc
index 4c494391427ac6497403dd34a16471994b6184f9..436744debb1b22d5a39c7368c7117f7c111a4c29 100644
--- a/content/renderer/render_widget_fullscreen.cc
+++ b/content/renderer/render_widget_fullscreen.cc
@@ -25,9 +25,11 @@ void RenderWidgetFullscreen::show(blink::WebNavigationPolicy) {
}
RenderWidgetFullscreen::RenderWidgetFullscreen(
+ int32_t widget_routing_id,
CompositorDependencies* compositor_deps,
const ScreenInfo& screen_info)
- : RenderWidget(compositor_deps,
+ : RenderWidget(widget_routing_id,
+ compositor_deps,
blink::WebPopupTypeNone,
screen_info,
false,
@@ -44,14 +46,6 @@ WebWidget* RenderWidgetFullscreen::CreateWebWidget() {
bool RenderWidgetFullscreen::Init(int32_t opener_id) {
DCHECK(!GetWebWidget());
- // Synchronous IPC to obtain a routing id for ourselves.
- int32_t routing_id = MSG_ROUTING_NONE;
- if (!RenderThreadImpl::current_render_message_filter()
- ->CreateFullscreenWidget(opener_id, &routing_id)) {
- return false;
- }
-
- RenderWidget::InitRoutingID(routing_id);
RenderWidget::Init(opener_id, CreateWebWidget());
return true;
}
« no previous file with comments | « content/renderer/render_widget_fullscreen.h ('k') | content/renderer/render_widget_fullscreen_pepper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698