Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: content/renderer/render_widget.h

Issue 2493293002: RenderWidget: make routing_id be a parameter of the ctor (Closed)
Patch Set: Add a release for asan bots. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index 7ee7dfee76c9813bab3c7c11e843500f3d4f4118..22f071a8b6d394c02e93e3e6b7de8355c8b014cc 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -142,13 +142,13 @@ class CONTENT_EXPORT RenderWidget
// Used by content_layouttest_support to hook into the creation of
// RenderWidgets.
- using CreateRenderWidgetFunction =
- RenderWidget* (*)(CompositorDependencies*,
- blink::WebPopupType,
- const ScreenInfo&,
- bool,
- bool,
- bool);
+ using CreateRenderWidgetFunction = RenderWidget* (*)(int32_t,
+ CompositorDependencies*,
+ blink::WebPopupType,
+ const ScreenInfo&,
+ bool,
+ bool,
+ bool);
using RenderWidgetInitializedCallback = void (*)(RenderWidget*);
static void InstallCreateHook(
CreateRenderWidgetFunction create_render_widget,
@@ -159,9 +159,7 @@ class CONTENT_EXPORT RenderWidget
// https://crbug.com/545684
virtual void CloseForFrame();
- int32_t routing_id() const {
- return routing_id_;
- }
+ int32_t routing_id() const { return routing_id_; }
CompositorDependencies* compositor_deps() const { return compositor_deps_; }
virtual blink::WebWidget* GetWebWidget() const;
@@ -426,7 +424,8 @@ class CONTENT_EXPORT RenderWidget
NO_RESIZE_ACK,
};
- RenderWidget(CompositorDependencies* compositor_deps,
+ RenderWidget(int32_t widget_routing_id,
+ CompositorDependencies* compositor_deps,
blink::WebPopupType popup_type,
const ScreenInfo& screen_info,
bool swapped_out,
@@ -442,10 +441,6 @@ class CONTENT_EXPORT RenderWidget
// Creates a WebWidget based on the popup type.
static blink::WebWidget* CreateWebWidget(RenderWidget* render_widget);
- // Called by Create() functions and subclasses, after the routing_id is
- // available. Must be called before Init().
- void InitRoutingID(int32_t routing_id);
-
// Called by Create() functions and subclasses to finish initialization.
void Init(int32_t opener_id, blink::WebWidget* web_widget);
@@ -608,8 +603,8 @@ class CONTENT_EXPORT RenderWidget
void OnWaitNextFrameForTests(int routing_id);
// Routing ID that allows us to communicate to the parent browser process
- // RenderWidgetHost. When MSG_ROUTING_NONE, no messages may be sent.
- int32_t routing_id_;
+ // RenderWidgetHost.
+ const int32_t routing_id_;
// Dependencies for initializing a compositor, including flags for optional
// features.
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698