Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2493293002: RenderWidget: make routing_id be a parameter of the ctor (Closed)
Patch Set: Add a release for asan bots. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/mus/compositor_mus_connection_unittest.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 9dfaccb56b14242e7120ab845a0c505c0ac7e783..571c2f9fecf70ce2eec1d463d9a6ddd75591046e 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1342,11 +1342,21 @@ void RenderFrameImpl::PepperSelectionChanged(
RenderWidgetFullscreenPepper* RenderFrameImpl::CreatePepperFullscreenContainer(
PepperPluginInstanceImpl* plugin) {
GURL active_url;
- if (render_view_->webview())
+ if (render_view()->webview())
active_url = render_view()->GetURLForGraphicsContext3D();
+
+ // Synchronous IPC to obtain a routing id for the fullscreen widget.
+ int32_t fullscreen_widget_routing_id = MSG_ROUTING_NONE;
+ if (!RenderThreadImpl::current_render_message_filter()
+ ->CreateFullscreenWidget(render_view()->routing_id(),
+ &fullscreen_widget_routing_id)) {
+ return nullptr;
+ }
+
RenderWidgetFullscreenPepper* widget = RenderWidgetFullscreenPepper::Create(
- render_view()->routing_id(), GetRenderWidget()->compositor_deps(),
- plugin, active_url, GetRenderWidget()->screen_info());
+ fullscreen_widget_routing_id, render_view()->routing_id(),
+ GetRenderWidget()->compositor_deps(), plugin, active_url,
+ GetRenderWidget()->screen_info());
widget->show(blink::WebNavigationPolicyIgnore);
return widget;
}
« no previous file with comments | « content/renderer/mus/compositor_mus_connection_unittest.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698