Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: content/public/renderer/render_view_observer.cc

Issue 2493293002: RenderWidget: make routing_id be a parameter of the ctor (Closed)
Patch Set: Add a release for asan bots. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/mus/compositor_mus_connection_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/render_view_observer.cc
diff --git a/content/public/renderer/render_view_observer.cc b/content/public/renderer/render_view_observer.cc
index 305fbd7d414bedfa7f6d56d699073166a873e626..3f2a345902ccdab31d2e3081b57ace89b2ab0fcf 100644
--- a/content/public/renderer/render_view_observer.cc
+++ b/content/public/renderer/render_view_observer.cc
@@ -14,7 +14,6 @@ RenderViewObserver::RenderViewObserver(RenderView* render_view)
// |render_view_| can be null on unit testing or if Observe() is used.
if (render_view_) {
routing_id_ = render_view_->GetRoutingID();
- // TODO(jam/nick): bring this back DCHECK_NE(routing_id_, MSG_ROUTING_NONE);
render_view_->AddObserver(this);
}
}
@@ -47,7 +46,7 @@ void RenderViewObserver::RenderViewGone() {
void RenderViewObserver::Observe(RenderView* render_view) {
if (render_view_) {
render_view_->RemoveObserver(this);
- routing_id_ = 0;
+ routing_id_ = MSG_ROUTING_NONE;
}
render_view_ = static_cast<RenderViewImpl*>(render_view);
« no previous file with comments | « no previous file | content/renderer/mus/compositor_mus_connection_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698