RenderWidget: make routing_id be a parameter of the ctor

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <memory>
 
@@ skipping 640 matching lines @@
   int64_t TraceId() const override { return latency_info_.trace_id(); }
 
  private:
   ui::LatencyInfo latency_info_;
 };
 
 }  // namespace
 
 RenderViewImpl::RenderViewImpl(CompositorDependencies* compositor_deps,
                                const mojom::CreateViewParams& params)
-    : RenderWidget(compositor_deps,
+    : RenderWidget(params.view_id,
+                   compositor_deps,
                    blink::WebPopupTypeNone,
                    params.initial_size.screen_info,
                    params.swapped_out,
                    params.hidden,
                    params.never_visible),
       webkit_preferences_(params.web_preferences),
       send_content_state_immediately_(false),
       enabled_bindings_(0),
       send_preferred_size_changes_(false),
       navigation_gesture_(NavigationGestureUnknown),
@@ skipping 18 matching lines @@
       expected_content_intent_id_(0),
 #endif
       enumeration_completion_id_(0),
       session_storage_namespace_id_(params.session_storage_namespace_id),
       has_added_input_handler_(false) {
   GetWidget()->set_owner_delegate(this);
 }
 
 void RenderViewImpl::Initialize(const mojom::CreateViewParams& params,
                                 bool was_created_by_renderer) {
-  RenderWidget::InitRoutingID(params.view_id);
+  RenderWidget::InitInputHandler();

[lfg, 2016/11/14 22:09:59]

Why do you need to add this? I assume tests were failing. Can you add a comment
explaining?

[ncarter (slow), 2016/11/14 23:33:56]

It wasn't strictly necessary; I figured that so long as I had InitInputHandler()
around, I could preserve the old ordering in case there was any unseen
dependency between WebView::create(this) and the input handler.

However, I went back and figured out the render_widget_unittest situation, which
was a leak due to an unbalanced bare AddRef(). So now, InitInputHandler is gone
again.

 
   int opener_view_routing_id = MSG_ROUTING_NONE;
   WebFrame* opener_frame = RenderFrameImpl::ResolveOpener(
       params.opener_frame_route_id, &opener_view_routing_id);
   if (!was_created_by_renderer)
     opener_view_routing_id = MSG_ROUTING_NONE;
 
   display_mode_ = params.initial_size.display_mode;
 
   webview_ =
@@ skipping 2258 matching lines @@
                             INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
   }
 
   std::unique_ptr<InputEventAck> ack(
       new InputEventAck(InputEventAckSource::MAIN_THREAD, input_event->type,
                         INPUT_EVENT_ACK_STATE_NOT_CONSUMED));
   OnInputEventAck(std::move(ack));
 }
 
 }  // namespace content