Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2493273002: [Mac] Fix tab dragging in RTL (Closed)

Created:
4 years, 1 month ago by lgrey
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix tab dragging in RTL BUG=648559 Committed: https://crrev.com/69c69e8b4dc28142dd4655e205f5ccd938569a00 Cr-Commit-Position: refs/heads/master@{#432012}

Patch Set 1 #

Patch Set 2 : Stray log #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
lgrey
PTAL :) Elly for RTL, Robert for OWNERS
4 years, 1 month ago (2016-11-11 17:39:45 UTC) #2
Robert Sesek
LGTM though you may want to wait for Elly too
4 years, 1 month ago (2016-11-11 19:24:43 UTC) #3
Elly Fong-Jones
lgtm
4 years, 1 month ago (2016-11-14 13:55:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493273002/20001
4 years, 1 month ago (2016-11-14 15:24:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493273002/20001
4 years, 1 month ago (2016-11-14 20:05:14 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 00:23:06 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 00:34:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69c69e8b4dc28142dd4655e205f5ccd938569a00
Cr-Commit-Position: refs/heads/master@{#432012}

Powered by Google App Engine
This is Rietveld 408576698