Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2493243002: Roll clang 284979-1:284979-2 (update style plugin) (Closed)

Created:
4 years, 1 month ago by hans
Modified:
4 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll clang 284979-1:284979-2 (update style plugin) Ran `tools/clang/scripts/upload_revision.py 284979 2`. This doesn't change the Clang version, but picks up Chromium #431450 which contains a fix for the style plugin. BUG=663463 Committed: https://crrev.com/d57e2e35e306be47b0dc96337a131c6e28f1c387 Cr-Commit-Position: refs/heads/master@{#431999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
hans
Please take a look.
4 years, 1 month ago (2016-11-14 17:54:08 UTC) #4
Nico
Lgtm, we could've used a real roll too though I suppose...
4 years, 1 month ago (2016-11-14 18:05:53 UTC) #6
hans
I've filed crbug.com/665063 and will get to work on the ToT bots since it's my ...
4 years, 1 month ago (2016-11-14 18:14:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493243002/1
4 years, 1 month ago (2016-11-14 20:43:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 00:06:02 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 00:11:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d57e2e35e306be47b0dc96337a131c6e28f1c387
Cr-Commit-Position: refs/heads/master@{#431999}

Powered by Google App Engine
This is Rietveld 408576698