Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: components/exo/surface_unittest.cc

Issue 2493223002: Change exo::SurfaceFactoryOwner to exo::ExoCompositorFrameSink (Closed)
Patch Set: Undid a change on an if condition in exo::Surface::CommitSurfaceHierarchy() Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/exo/surface_unittest.cc
diff --git a/components/exo/surface_unittest.cc b/components/exo/surface_unittest.cc
index 570e4acc075f2dd03a7c9ac3063e76fca51e88c8..18e5d6d1a7236427af5f12b84504cf7e3c9b0864 100644
--- a/components/exo/surface_unittest.cc
+++ b/components/exo/surface_unittest.cc
@@ -26,6 +26,7 @@ void ReleaseBuffer(int* release_buffer_call_count) {
(*release_buffer_call_count)++;
}
+// SurafaceTest.Attach is failing
TEST_F(SurfaceTest, Attach) {
gfx::Size buffer_size(256, 256);
std::unique_ptr<Buffer> buffer(
@@ -50,6 +51,7 @@ TEST_F(SurfaceTest, Attach) {
// attached buffer.
surface->Attach(nullptr);
surface->Commit();
+ RunAllPendingInMessageLoop();
Fady Samuel 2016/11/30 16:41:57 Add a comment about why this is necessary.
Alex Z. 2016/11/30 20:00:30 Done.
ASSERT_EQ(1, release_buffer_call_count);
}
@@ -247,7 +249,6 @@ TEST_F(SurfaceTest, SetAlpha) {
TEST_F(SurfaceTest, Commit) {
std::unique_ptr<Surface> surface(new Surface);
-
// Calling commit without a buffer should succeed.
surface->Commit();
}

Powered by Google App Engine
This is Rietveld 408576698